Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/email verification form and notice #94683

Draft
wants to merge 19 commits into
base: trunk
Choose a base branch
from

Conversation

Addison-Stavlo
Copy link
Contributor

@Addison-Stavlo Addison-Stavlo commented Sep 18, 2024

Related to # #93895 and #94247

Proposed Changes

WIP - removing some notices, adding a banner, adding functionality to unlock input, etc. as outlined in those two issues. Dialog/Modal changes are applied separately in #94629

Why are these changes being made?

Testing Instructions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Sep 18, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~140 bytes removed 📉 [gzipped])

name                   parsed_size           gzip_size
entry-stepper              +1009 B  (+0.0%)     -163 B  (-0.0%)
entry-main                 +1009 B  (+0.0%)     -118 B  (-0.0%)
entry-login                 -570 B  (-0.0%)     -224 B  (-0.0%)
entry-subscriptions         -421 B  (-0.0%)     -253 B  (-0.0%)
entry-domains-landing       -421 B  (-0.1%)     -170 B  (-0.1%)
entry-browsehappy           -421 B  (-0.2%)     -170 B  (-0.3%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~26469 bytes added 📈 [gzipped])

name                                parsed_size           gzip_size
site-blocks                            +44007 B  (+5.8%)   +15643 B  (+7.3%)
privacy                                +44007 B  (+6.0%)   +16169 B  (+7.7%)
me                                     +44007 B  (+6.2%)   +15644 B  (+7.7%)
developer                              +44007 B  (+5.9%)   +16211 B  (+7.7%)
account-close                          +44007 B  (+6.0%)   +15654 B  (+7.6%)
notification-settings                  +42870 B  (+5.1%)   +15518 B  (+6.6%)
help                                   +42784 B  (+5.7%)   +15810 B  (+7.5%)
security                               +35561 B  (+3.7%)   +12843 B  (+4.8%)
account                                +34388 B  (+3.8%)   +12798 B  (+4.9%)
purchases                               +8715 B  (+0.4%)    +4961 B  (+0.9%)
site-purchases                           +537 B  (+0.0%)    +1547 B  (+0.4%)
stats                                    -523 B  (-0.0%)    +1093 B  (+0.3%)
people                                   -488 B  (-0.1%)     -362 B  (-0.2%)
themes                                   -457 B  (-0.0%)    -1389 B  (-0.5%)
domains                                  +409 B  (+0.0%)    +1565 B  (+0.3%)
checkout                                 -368 B  (-0.0%)     -280 B  (-0.1%)
settings-newsletter                      -348 B  (-0.1%)     +264 B  (+0.2%)
marketplace                              +321 B  (+0.0%)    +1962 B  (+0.7%)
import                                   +274 B  (+0.0%)     -702 B  (-0.3%)
settings-writing                         -245 B  (-0.0%)      -65 B  (-0.0%)
hosting                                  -227 B  (-0.0%)    -1045 B  (-0.2%)
plans                                    -203 B  (-0.0%)     -859 B  (-0.2%)
settings                                 +161 B  (+0.0%)    +2185 B  (+0.8%)
home                                     +157 B  (+0.0%)    +1005 B  (+0.2%)
jetpack-cloud-settings                   -132 B  (-0.0%)     -715 B  (-0.4%)
link-in-bio-tld-flow                     -111 B  (-0.0%)      -37 B  (-0.0%)
update-design-flow                        -87 B  (-0.0%)      -42 B  (-0.0%)
signup                                    -87 B  (-0.0%)      -34 B  (-0.1%)
write-flow                                -63 B  (-0.0%)      -22 B  (-0.0%)
videopress-flow                           -63 B  (-0.0%)      -22 B  (-0.0%)
staging-site                              -63 B  (-0.0%)      -25 B  (-0.0%)
settings-security                         -63 B  (-0.0%)      -22 B  (-0.0%)
settings-performance                      -63 B  (-0.0%)      -23 B  (-0.0%)
posts-custom                              -63 B  (-0.0%)     +231 B  (+0.1%)
posts                                     -63 B  (-0.0%)     +231 B  (+0.1%)
plugins                                   -63 B  (-0.0%)     +542 B  (+0.1%)
marketing                                 -63 B  (-0.0%)      -23 B  (-0.0%)
jetpack-cloud-plugin-management           -63 B  (-0.0%)     +347 B  (+0.1%)
earn                                      -63 B  (-0.0%)      -22 B  (-0.0%)
build-flow                                -63 B  (-0.0%)      -24 B  (-0.0%)
activity                                  -63 B  (-0.0%)     +134 B  (+0.1%)
woocommerce-installation                  -39 B  (-0.0%)      -17 B  (-0.0%)
woocommerce                               -39 B  (-0.0%)      -18 B  (-0.0%)
subscribers                               -39 B  (-0.0%)      -17 B  (-0.0%)
sites-dashboard                           -39 B  (-0.0%)      -19 B  (-0.0%)
site-performance                          -39 B  (-0.0%)      -19 B  (-0.0%)
site-monitoring                           -39 B  (-0.0%)      -19 B  (-0.0%)
site-logs                                 -39 B  (-0.0%)      -19 B  (-0.0%)
settings-reading                          -39 B  (-0.0%)      -17 B  (-0.0%)
settings-jetpack                          -39 B  (-0.0%)      -17 B  (-0.0%)
settings-discussion                       -39 B  (-0.0%)      -17 B  (-0.0%)
sensei-flow                               -39 B  (-0.0%)      -17 B  (-0.0%)
scan                                      -39 B  (-0.0%)      -17 B  (-0.0%)
promote-post-i2                           -39 B  (-0.0%)      -17 B  (-0.0%)
preview                                   -39 B  (-0.0%)      -17 B  (-0.0%)
patterns                                  -39 B  (-0.0%)       -9 B  (-0.0%)
pages                                     -39 B  (-0.0%)      -17 B  (-0.0%)
migrate                                   -39 B  (-0.0%)      -17 B  (-0.0%)
jetpack-social                            -39 B  (-0.0%)      -17 B  (-0.0%)
jetpack-search                            -39 B  (-0.0%)      -17 B  (-0.0%)
jetpack-connect                           -39 B  (-0.0%)     -368 B  (-0.1%)
jetpack-cloud-pricing                     -39 B  (-0.0%)     -182 B  (-0.1%)
jetpack-cloud-partner-portal              -39 B  (-0.0%)     -213 B  (-0.1%)
jetpack-cloud-overview                    -39 B  (-0.0%)      -17 B  (-0.0%)
jetpack-cloud-features-comparison         -39 B  (-0.0%)     -111 B  (-0.1%)
jetpack-cloud-agency-sites-v2             -39 B  (-0.0%)     -388 B  (-0.1%)
jetpack-cloud                             -39 B  (-0.0%)      -17 B  (-0.0%)
incoming-redirect                         -39 B  (-0.2%)      -17 B  (-0.2%)
hosting-features                          -39 B  (-0.0%)      -19 B  (-0.0%)
gutenberg-editor                          -39 B  (-0.0%)      -34 B  (-0.0%)
google-my-business                        -39 B  (-0.0%)      -17 B  (-0.0%)
github-deployments                        -39 B  (-0.0%)      -19 B  (-0.0%)
export                                    -39 B  (-0.0%)      -17 B  (-0.0%)
email                                     -39 B  (-0.0%)     +814 B  (+0.4%)
customize                                 -39 B  (-0.0%)      -17 B  (-0.0%)
copy-site-flow                            -39 B  (-0.0%)      -17 B  (-0.0%)
concierge                                 -39 B  (-0.0%)      -17 B  (-0.0%)
comments                                  -39 B  (-0.0%)      -17 B  (-0.0%)
backup                                    -39 B  (-0.0%)     -193 B  (-0.1%)
add-ons                                   -39 B  (-0.0%)      -17 B  (-0.0%)
a8c-for-agencies-team                     -39 B  (-0.0%)      -19 B  (-0.0%)
a8c-for-agencies-sites                    -39 B  (-0.0%)     -195 B  (-0.0%)
a8c-for-agencies-signup                   -39 B  (-0.0%)      -17 B  (-0.1%)
a8c-for-agencies-settings                 -39 B  (-0.0%)      -17 B  (-0.0%)
a8c-for-agencies-referrals                -39 B  (-0.0%)      -19 B  (-0.0%)
a8c-for-agencies-purchases                -39 B  (-0.0%)      -17 B  (-0.0%)
a8c-for-agencies-partner-directory        -39 B  (-0.0%)      -17 B  (-0.0%)
a8c-for-agencies-overview                 -39 B  (-0.0%)      -19 B  (-0.0%)
a8c-for-agencies-migrations               -39 B  (-0.0%)      -17 B  (-0.0%)
a8c-for-agencies-marketplace              -39 B  (-0.0%)      -17 B  (-0.0%)
a8c-for-agencies-client                   -39 B  (-0.0%)      -19 B  (-0.0%)
settings-podcast                          +34 B  (+0.0%)    +1204 B  (+0.8%)
theme                                     +32 B  (+0.0%)     -191 B  (-0.1%)
media                                     +30 B  (+0.0%)    +1445 B  (+0.3%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~22221 bytes added 📈 [gzipped])

name                                                                              parsed_size            gzip_size
async-load-signup-steps-p2-complete-profile                                          +16275 B  (+18.2%)    +4928 B  (+17.6%)
async-load-calypso-my-sites-checkout-modal                                             -235 B   (-0.0%)     -649 B   (-0.2%)
async-load-calypso-blocks-editor-checkout-modal                                        -196 B   (-0.0%)     -819 B   (-0.3%)
async-load-automattic-help-center                                                      +196 B   (+0.0%)     +725 B   (+0.4%)
async-load-calypso-post-editor-editor-media-modal                                      +172 B   (+0.0%)     +800 B   (+0.2%)
async-load-signup-steps-design-picker                                                  +100 B   (+0.2%)      -10 B   (-0.1%)
async-load-calypso-layout-masterbar-checkout-tsx                                        -71 B   (-0.1%)      -65 B   (-0.2%)
async-load-calypso-layout-masterbar-checkout                                            -71 B   (-0.1%)     -154 B   (-0.6%)
async-load-calypso-reader-sidebar                                                       -63 B   (-0.0%)      -24 B   (-0.1%)
async-load-signup-steps-page-picker                                                     -51 B   (-0.0%)      -30 B   (-0.0%)
async-load-purchase-modal-wrapper                                                       -51 B   (-0.0%)      -23 B   (-0.0%)
async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou...        -51 B   (-0.0%)      -58 B   (-0.1%)
async-load-signup-steps-emails                                                          -39 B   (-0.1%)      -17 B   (-0.1%)
async-load-signup-steps-domains                                                         -39 B   (-0.0%)      -17 B   (-0.0%)
async-load-design-blocks                                                                -24 B   (-0.0%)       +2 B   (+0.0%)
async-load-calypso-my-sites-stats-summary                                               -24 B   (-0.0%)       -8 B   (-0.1%)
async-load-calypso-my-sites-current-site-notice                                         -24 B   (-0.0%)       -7 B   (-0.0%)
async-load-calypso-components-web-preview-component                                     -24 B   (-0.0%)       -7 B   (-0.0%)
async-load-calypso-blocks-jitm-templates-sidebar-banner                                 -24 B   (-0.1%)       -5 B   (-0.0%)
async-load-calypso-blocks-jitm-templates-notice                                         -24 B   (-0.1%)       -6 B   (-0.0%)
async-load-calypso-blocks-jitm-templates-default                                        -24 B   (-0.1%)       -6 B   (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/email-verification-form-and-notice on your sandbox.

@Addison-Stavlo Addison-Stavlo self-assigned this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants