Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misaligned chat button #94716

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Fix misaligned chat button #94716

wants to merge 1 commit into from

Conversation

heavyweight
Copy link
Contributor

When disabling auto-renew for professional email, the chat button text was misaligned.

Before After
Screenshot 2024-09-19 at 14 42 11 Screenshot 2024-09-19 at 14 41 49

Related to #
#94698

Proposed Changes

  • Add missing styles to component

Why are these changes being made?

Testing Instructions

  • Add professional email to a site
  • /email/:site_slug/manage/:site_slug
  • Disable Auto-renew
  • The button "Need help? Contact us" should be correctly aligned to the left

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@heavyweight heavyweight added the Groundskeeping Issues handled through Dotcom Groundskeeping rotations label Sep 19, 2024
@heavyweight heavyweight self-assigned this Sep 19, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • notifications
  • odyssey-stats
  • whats-new
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix-misaligned-chat on your sandbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Groundskeeping Issues handled through Dotcom Groundskeeping rotations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants