-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Help Center to the migration flow #94735
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
ab10698
to
533f286
Compare
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~57 bytes removed 📉 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~213 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
@@ -135,39 +128,17 @@ function WhatsNewLoader( { loadWhatsNew, siteId } ) { | |||
); | |||
} | |||
|
|||
function HelpCenterLoader( { sectionName, loadHelpCenter, currentRoute } ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was extracted, so we can also use it in the Stepper
.
|
||
import './help-center-action-button.scss'; | ||
|
||
export const HelpCenterActionButton = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A new component to be easier to add the Help Center to the steps by passing this to the customizedActionButtons
prop of the StepContainer
component.
|
||
const AsyncHelpCenter = () => { | ||
const { setShowHelpCenter } = useDispatch( HELP_CENTER_STORE ); | ||
// TODO: The useSite uses the `useLocation`, but we are not adding it inside the router because HelpCenter also has its own router. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some challenges here to be fixed yet.
Related to #94548
Proposed Changes
Stepper
, so we can use Help Center in thesetup
flows.Screen.Recording.2024-09-19.at.19.37.21.mov
TODO
currentRoute
andsite
properly.Why are these changes being made?
Testing Instructions
Check that Help Center is fixed in the checkout
/setup/migration
.Check that Help Center is displayed post-checkout in the migration flows
Pre-merge Checklist