fix: Update default params and add associated UTs #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
default params need to be applied Signed-off-by: Ishaan Sehgal <[email protected]>
Signed-off-by: Ishaan Sehgal <[email protected]>
Signed-off-by: Ishaan Sehgal <[email protected]>
ishaansehgal99
had a problem deploying
to
preset-env
GitHub Actions
Error
Signed-off-by: Ishaan Sehgal <[email protected]>
ishaansehgal99
temporarily deployed
to
preset-env
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #294 +/- ##
=======================================
Coverage 65.33% 65.33%
=======================================
Files 14 14
Lines 1125 1125
=======================================
Hits 735 735
Misses 352 352
Partials 38 38 ☔ View full report in Codecov by Sentry. |
ishaansehgal99
temporarily deployed
to
preset-env
GitHub Actions
Inactive
Signed-off-by: Ishaan Sehgal <[email protected]>
ishaansehgal99
temporarily deployed
to
preset-env
GitHub Actions
Inactive
Fei-Guo
approved these changes
Mar 13, 2024
ishaansehgal99
temporarily deployed
to
preset-env
GitHub Actions
Inactive
ishaansehgal99
changed the title
ishaansehgal99
changed the title
helayoty
pushed a commit
that referenced
this pull request
Mar 17, 2024
Default parameters for text generation are here: https://huggingface.co/docs/transformers/en/main_classes/text_generation With growing list of params, I shorten the list here and add UT. --------- Signed-off-by: Ishaan Sehgal <[email protected]>
helayoty
pushed a commit
that referenced
this pull request
Mar 29, 2024
Default parameters for text generation are here: https://huggingface.co/docs/transformers/en/main_classes/text_generation With growing list of params, I shorten the list here and add UT. --------- Signed-off-by: Ishaan Sehgal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default parameters for text generation are here: https://huggingface.co/docs/transformers/en/main_classes/text_generation
With growing list of params, I shorten the list here and add UT.