chore: adapter validation e2e #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangqipropel
requested review from
Fei-Guo,
helayoty and
ishaansehgal99
as code owners
bangqipropel
force-pushed
the
bangqipropel/adapter_validation_e2e
branch
from
4d0c39f
to
d5fc713
Compare
bangqipropel
force-pushed
the
bangqipropel/adapter_validation_e2e
branch
from
d5fc713
to
4b6e055
Compare
bangqipropel
force-pushed
the
bangqipropel/adapter_validation_e2e
branch
from
4b6e055
to
4b2e951
Compare
bangqipropel
force-pushed
the
bangqipropel/adapter_validation_e2e
branch
from
4b2e951
to
4ed372e
Compare
bangqipropel
force-pushed
the
bangqipropel/adapter_validation_e2e
branch
from
4ed372e
to
d4e36fd
Compare
bangqipropel
changed the title
bangqipropel
force-pushed
the
bangqipropel/adapter_validation_e2e
branch
from
55d9b21
to
b65dffb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #549 +/- ##
=======================================
Coverage 58.18% 58.18%
=======================================
Files 30 30
Lines 2987 2987
=======================================
Hits 1738 1738
Misses 1149 1149
Partials 100 100 ☔ View full report in Codecov by Sentry. |
|
The changes in test/e2e/preset_test.go and pkg/inference/preset-inferences.go are only for e2e test without changing the mcr image, this can be reviewed for if we can use this way to test it for now. |
bangqipropel
force-pushed
the
bangqipropel/adapter_validation_e2e
branch
from
b65dffb
to
025e842
Compare
bangqipropel
force-pushed
the
bangqipropel/adapter_validation_e2e
branch
from
025e842
to
40a8515
Compare
bangqipropel
had a problem deploying
to
unit-tests
GitHub Actions
Error
bangqipropel
had a problem deploying
to
preset-env
GitHub Actions
Failure
bangqipropel
had a problem deploying
to
preset-env
GitHub Actions
Failure
Signed-off-by: Bangqi Zhu <[email protected]>
bangqipropel
force-pushed
the
bangqipropel/adapter_validation_e2e
branch
from
40a8515
to
1c4122e
Compare
bangqipropel
temporarily deployed
to
unit-tests
GitHub Actions
Inactive
Fei-Guo
approved these changes
Aug 23, 2024
smritidahal653
pushed a commit
to smritidahal653/kaito
that referenced
this pull request
Sep 18, 2024
**Reason for Change**: Add adapters validation to e2e tests. **Requirements** - [ ] added unit tests and e2e tests (if applicable). **Issue Fixed**: <!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next line. --> **Notes for Reviewers**: Signed-off-by: Bangqi Zhu <[email protected]> Co-authored-by: Bangqi Zhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Add adapters validation to e2e tests.
Requirements
Issue Fixed:
Notes for Reviewers: