Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MSAL.js ADFS documentation to describe requirement for Cross Origin Resource Sharing (CORS) headers #7235

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

billvolt
Copy link

@billvolt billvolt commented Aug 6, 2024

MSAL.js requires CORS. AAD provides CORS headers, but ADFS 2019 does not do so by default. Describe CORS requirement for use with ADFS.

Describe CORS requirement for use with ADFS.
@github-actions github-actions bot added documentation Related to documentation. msal-common Related to msal-common package labels Aug 6, 2024
@billvolt billvolt marked this pull request as draft August 6, 2024 21:12
@billvolt
Copy link
Author

billvolt commented Aug 6, 2024

Corrected grammar: directly connection -> directly connecting

Added protocolMode property must be set to "OIDC".

@billvolt billvolt marked this pull request as ready for review August 6, 2024 21:15
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Awaiting response from the MSAL.js team label Aug 26, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Attention 👋 Awaiting response from the MSAL.js team label Aug 26, 2024
@billvolt billvolt closed this Aug 26, 2024
@billvolt billvolt reopened this Aug 26, 2024
Copy link
Contributor

Reminder: This PR appears to be stale. If this PR is still a work in progress please mark as draft.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Awaiting response from the MSAL.js team label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation. msal-common Related to msal-common package Needs: Attention 👋 Awaiting response from the MSAL.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants