IDownstreamApi overloads that take JsonTypeInfo<T> as a parameter to enable source generated Json deserialization for NativeAOT #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmprieur
approved these changes
Jul 19, 2024
src/Microsoft.Identity.Abstractions/DownstreamApi/IDownstreamApi.HttpMethods.tt
Show resolved
Hide resolved
src/Microsoft.Identity.Abstractions/DownstreamApi/IDownstreamApi.HttpMethods.tt
Outdated
Show resolved
Hide resolved
| /// return _downstreamWebApi.CallWebApiForUserAsync<MyItem, MyItem>( | ||
| /// ServiceName, | ||
| /// nyItem, | ||
| /// options => |
There was a problem hiding this comment.
You might want to update this code snippet (which goes in the reference documentation). See the Examples paragraph of https://learn.microsoft.com/en-us/dotnet/api/microsoft.identity.abstractions.idownstreamapi.callapiforuserasync?view=msal-model-dotnet-latest for instance
src/Microsoft.Identity.Abstractions/Microsoft.Identity.Abstractions.csproj
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Jul 24, 2024
src/Microsoft.Identity.Abstractions/DownstreamApi/IDownstreamApi.HttpMethods.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Jul 24, 2024
eerhardt
reviewed
Jul 26, 2024
eerhardt
reviewed
Jul 26, 2024
eerhardt
reviewed
Jul 26, 2024
src/Microsoft.Identity.Abstractions/CompatibilitySuppressions.xml
Outdated
Show resolved
Hide resolved
src/Microsoft.Identity.Abstractions/DownstreamApi/IDownstreamApi.HttpMethods.tt
Show resolved
Hide resolved
eerhardt
approved these changes
Jul 26, 2024
src/Microsoft.Identity.Abstractions/DownstreamApi/IDownstreamApi.HttpMethods.tt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AzureAD/microsoft-identity-web#2930
Adding overloads to IDownstreamApi that accept JsonTypeInfo for inputs / outputs so that source generated Json serialization can work in a NativeAOT context.