Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes for 6DoF #14911

Merged
merged 5 commits into from
Mar 27, 2024
Merged

Some fixes for 6DoF #14911

merged 5 commits into from
Mar 27, 2024

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Mar 26, 2024

  • isNearGrabbable is now set on the mesh and its children (will enable grabbing glTFs as well)
  • If the attached controller changes in XR and the last controller had a pointer down triggered, a pointer up event will trigger (caused an issue with 6DoF)
  • Multipointer in WebXR is disabled (temporary) until an issue with touching multipointers will be solved.
  • Docs updated for more clarity
  • XR evets are treated the same in 6DoF, meaning a remote controller can now rotate a model when using 6DoF behavior.

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 26, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 26, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 26, 2024

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14911/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 26, 2024

@matthargett
Copy link

Multipointer in WebXR is disabled (temporary) until an issue with touching multipointers will be solved.

Is there an issue filed to track this issue? Does it need an explicit mention in the release notes?

@RaananW
Copy link
Member Author

RaananW commented Mar 26, 2024

Multipointer in WebXR is disabled (temporary) until an issue with touching multipointers will be solved.

Is there an issue filed to track this issue? Does it need an explicit mention in the release notes?

I will be working on that tomorrow, but if I can't fully debug and fix it tomorrow we will keep it disabled for 7.0. I will either fix it or create an issue to track it.

packages/dev/core/src/Meshes/abstractMesh.ts Outdated Show resolved Hide resolved
@RaananW RaananW enabled auto-merge (squash) March 27, 2024 12:22
@RaananW RaananW disabled auto-merge March 27, 2024 12:22
@bjsplat
Copy link
Collaborator

bjsplat commented Mar 27, 2024

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14911/merge/testResults/webgpuplaywright/index.html

@RaananW RaananW merged commit 470b08c into BabylonJS:master Mar 27, 2024
11 checks passed
@RaananW RaananW deleted the XRFix6DoF branch March 27, 2024 16:54
@RaananW
Copy link
Member Author

RaananW commented Mar 27, 2024

Multipointer in WebXR is disabled (temporary) until an issue with touching multipointers will be solved.

Is there an issue filed to track this issue? Does it need an explicit mention in the release notes?

Issue for tracking - #14914

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants