CMake minimum required 3.0 -> 3.1 #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# minimum required 3.0 is a bit contradiction to my experience. it should be 3.1 # because CMake 3.1 introduced the CMAKE_CXX_STANDARD. Cmake 3.1 compiles fine, # but CMake 3.0 does not have the CMAKE_CXX_STANDARD and then it does not use cxx11 # then you hit error: # expected template-name before ‘<’ token error enabled_shared_from_this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minimum required 3.0 is a bit contradiction to my experience. it should be 3.1
because CMake 3.1 introduced the CMAKE_CXX_STANDARD. Cmake 3.1 compiles fine,
but CMake 3.0 does not have the CMAKE_CXX_STANDARD and then it does not use cxx11
then you hit error:
expected template-name before ‘<’ token error enabled_shared_from_this