Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating budibase apps image to use alpine #14564

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

shogunpurple
Copy link
Member

Description

Updating our budibase/apps image to use alpine instead of slim. This is part of the ongoing work to reduce vulnerabilities in our image for an enterprise prospect. Following this merge, I can use the new alpine based hardened image as the base image for both apps and worker.

Steps:

  • converted server Dockerfile and built it locally
  • Used the new alpine based dockerfile in a docker compose configuration. Works as expected
  • docker image ls shows that this image is now 880MB instead of the standard budibase/apps 1.16GB, so a nice saving just for updating to alpine

Addresses

@shogunpurple shogunpurple marked this pull request as ready for review September 11, 2024 16:48
@shogunpurple shogunpurple requested a review from a team as a code owner September 11, 2024 16:48
@shogunpurple shogunpurple requested review from samwho and removed request for a team September 11, 2024 16:48
Copy link
Contributor

@calexiou calexiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@shogunpurple shogunpurple merged commit 50de6a1 into master Sep 11, 2024
12 checks passed
@shogunpurple shogunpurple deleted the docker-security-updates branch September 11, 2024 16:59
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants