Part 2 of 2 - Budi 8608 ai platform level config #14602
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ai-platform-level-config-pt-2
shogunpurple
changed the title
…Budibase/budibase into budi-8608-ai-platform-level-config-pt-2
samwho
requested changes
Sep 19, 2024
| // unset the default value from other configs if default is set | ||
| if (editingAIConfig.isDefault) { | ||
| for (let key in fullAIConfig.config) { | ||
| fullAIConfig.config[key].isDefault = false | ||
| if (key !== id) { |
There was a problem hiding this comment.
I don't quite understand this change. The old code looks correct, what does this fix?
There was a problem hiding this comment.
Since it iterates through all the configs, It unsets the new one you actually want to set to default back to false, so it needs to know not to do that
Comment on lines
+352
to
+356
| for (const key in scopedConfig.config) { | ||
| if (scopedConfig.config[key].apiKey) { | ||
| scopedConfig.config[key].apiKey = PASSWORD_REPLACEMENT | ||
| } | ||
| } |
There was a problem hiding this comment.
We need a test to prevent us ever breaking this behaviour by accident.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows budibase to inject the AI configs that can be created with #14543 into LLM providers. Right now, the only place we have AI in the platform is in automations, so support is provided there to allow users who already use the OpenAI integration to continue as is, but users who have access to Budibase AI on paid plans can use custom configs, such as Anthropic instead of OpenAI.
All the LLM code (a majority of this work) is wrapped up in this budibase pro repo. There's further context there on how the LLM integration works, but I tried to keep it as abstracted as possible (including reading the config etc) in pro, so it can just be pulled in and used in a few lines anywhere in the platform that we need AI, and has a dependency on
@budibase/pro.https://github.com/Budibase/budibase-pro/pull/320
Addresses
https://linear.app/budibase/issue/BUDI-8608/ai-platform-level-config
There are 2 parts to the above:
Launchcontrol
Add the ability to use custom AI configs and the built in budibase AI in cloud for automations