Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: revert recent incorrect change to SvelteKit destination #622

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

benmccann
Copy link
Contributor

@benmccann benmccann commented Sep 4, 2024

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

Reverts #552 by @gioboa and #591 by @aajaces.

Use cases and why

There's no description in #552, so I can't understand why it was thought to be an improvement. There are multiple issues with it though:

  • it's additional configuration that makes the project harder to setup
  • it sends the output to a source directory instead of the correct ___location which is SvelteKit's output directory (the default)
  • __dirname is not defined in an ESM file, so it's broken without a couple more lines to add that variable

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

Copy link

vercel bot commented Sep 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
partytown ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 6:28pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant