This repository has been archived by the owner on Jan 21, 2022. It is now read-only.
Block->ommers shows ommers of a given block. #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhila-raju
changed the title
raulk
reviewed
Aug 9, 2018
| @@ -117,6 +117,23 @@ export class EthqlBlock implements EthqlBlock { | |||
| } | |||
| } | |||
|
|
|||
| export interface EthqlOmmerBlock | |||
There was a problem hiding this comment.
@akhila-raju – maybe you could elaborate on why it was necessary to introduce a separate class for ommer blocks?
Also why overwrite the miner property in this PR and not in #102?
There was a problem hiding this comment.
Sure - the reasons why I introduced a separate class for ommers is because ommers don't contain transactions:
- transactions shouldn't be a property on ommers if they don't exist
- transactionsCount will always return null for ommers
Rather than carry down a check for whether the block is an ommer block, I decided to create a new class to simplify things.
The miner property was already EthqlAccount, it wasn't overwritten - just copied and pasted for EthqlOmmerBlock :)
raulk
reviewed
Aug 9, 2018
raulk
reviewed
Aug 9, 2018
raulk
reviewed
Aug 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #101.