-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add execute_sql_rds.sh
script to run SQL using RDS Data API
#1847
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good / much simpler than logging into the AWS console
api/bin/execute_sql_rds.sh
Outdated
RESOURCE_ARN='arn:aws:rds:...' | ||
SECRET_ARN='arn:aws:secretsmanager:...' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if it would be an issue, but what about making these env vars (or params passed in) so someone is less likely to accidentally check in the ARNs?
Also - it would be good to know what user / role access a person has with this - can this only be the root user? Might be a problem we address later with our own login roles and what they have access to use (ie. almost anyone with AWS access can use a read-only role, only admins can write)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking fancy!
GREEN='\033[92m' | ||
END='\033[0m' | ||
|
||
CLUSTER=api-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLUSTER=api-dev | |
# Defaults the --cluster argument to api-dev | |
CLUSTER=api-dev |
Summary
Fixes #{ISSUE}
Time to review: x mins
Changes proposed
execute_sql_rds.sh
script to run SQL using RDS Data APIContext for reviewers
During development, this can make it easier to run queries against the dev database.
Additional information