[Issue #2030] Adjust opportunity response to contain the agency name #2182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
sumiat,
widal001 and
andycochran
as code owners
github-actions
bot
added
the
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2030
Time to review: 5 mins
Changes proposed
Add the agency name to the opportunity response
Make it so the agency name can be fetched in the opportunity model
Context for reviewers
Recent work added a table for agency data, and while this won't be populated for a bit (needs some testing in the lower envs), the tables themselves are setup. This will attempt to fetch the agency, and if found cause the name to be returned. This is technically how the agency name works in the current system although the schema of the agency is quite a bit different.
Additional information
Works both for the data loaded into the search index as well as the data returned by the GET /opportunity endpoint:
