Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastfec: build with older zig #190831

Merged
merged 1 commit into from
Sep 17, 2024
Merged

fastfec: build with older zig #190831

merged 1 commit into from
Sep 17, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Sep 16, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@cho-m cho-m added the CI-no-bottles Merge without publishing bottles label Sep 16, 2024
@github-actions github-actions bot added the zig Zig use is a significant feature of the PR or issue label Sep 16, 2024
@cho-m cho-m added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Sep 16, 2024
Formula/f/fastfec.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 17, 2024
Co-authored-by: Carlo Cabrera <[email protected]>
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 17, 2024
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should just upstream a Makefile or a CMakeLists.txt; doesn't seem like a hugely complicated project.

@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 17, 2024
Merged via the queue into master with commit 842693f Sep 17, 2024
22 checks passed
@BrewTestBot BrewTestBot deleted the fastfec-zig branch September 17, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. zig Zig use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants