Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vietnamese glyphs #137

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Add Vietnamese glyphs #137

wants to merge 11 commits into from

Commits on Feb 18, 2024

  1. generate: allow to specify where to place diacritics

    Various scripts have diacritics on positions other than the top of base
    characters. This commit adds support for the (optional) `placement` key
    in diacritic.json, allowing diacritics to be placed in any of the four
    positions: above, below, to the left, and to the right of the glyph.
    The default when not specified is "above".
    The placement respects the spacing specified by the `diacriticSpace`
    key in characters.json.
    Nekosha committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    0533aa0 View commit details
    Browse the repository at this point in the history
  2. generate: add support for multiple diacritics on a single glyph

    This allows to define a glyph with multiple diacritics attached.
    Currently overlaps are not handled (spacing is currently shared for
    all of them), meaning stacking diacritics in the same direction is not
    possible.
    Nekosha committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    b3870ba View commit details
    Browse the repository at this point in the history
  3. metadata: add various missing glyphs for Vietnamese

    This adds various missing glyphs for Vietnamese.
    Note that some characters require multiple diacritics in different positions.
    
    There is a hack in diacritics.json to force monocraft.py to include many
    glyphs in the generation step. For example, the glyph "LATIN SMALL LETTER
    A WITH CIRCUMFLEX AND DOT BELOW" contain two diacritics `circumflex` and
    `dot_below`. generate_diacritics.py parses this as containing one
    diacritic: `circumflex_and_dot_below`, which it will not find in
    diacritics.json without this hack, and thus the glyph will not be
    generated.
    For a proper fix, the logic to determine which diacritics should be
    considered (lines 37-38, generate_diacritics.py) should be fixed to
    consult the list in characters.json instead.
    Nekosha committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    e257b9b View commit details
    Browse the repository at this point in the history
  4. generate: add support for offsetting the diacritic

    This commit adds support for two optional keys in diacritics.json: offsetX and offsetY. This allows the glyph to be shifted relative to the base position.
    Nekosha committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    a325aeb View commit details
    Browse the repository at this point in the history
  5. generate: raise glyph ascent height

    Some Vietnamese glyphs are very tall with their diacritics, which causes the top of them to sometimes be cut off in some programs. This raises the font ascent by 1 pixel size to accomodate those glyphs.
    As a side effect, however, this also messes with font sizing in a lot of programs.
    Nekosha committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    b81e925 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    655dcff View commit details
    Browse the repository at this point in the history
  7. glyph: change horn characters to be identical to Minecraft

    The original variant looks better in text, but is different from the
    font in-game.
    Nekosha committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    cd0fc82 View commit details
    Browse the repository at this point in the history
  8. diacritic: offset diacritics to be identical to Minecraft

    The original variant looks better in text, but is different from the
    font in-game.
    Nekosha committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    40c1f92 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. generate: bump ascent height for very taaaaall Vietnamese glyphs

    The last size bump did not take into account capital letters.
    Nekosha committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    b85f12b View commit details
    Browse the repository at this point in the history
  2. generate: more descent

    Nekosha committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    d9580be View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2024

  1. make base a dotless i

    Nekosha committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    49e3adc View commit details
    Browse the repository at this point in the history