-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Vietnamese glyphs #137
base: main
Are you sure you want to change the base?
Commits on Feb 18, 2024
-
generate: allow to specify where to place diacritics
Various scripts have diacritics on positions other than the top of base characters. This commit adds support for the (optional) `placement` key in diacritic.json, allowing diacritics to be placed in any of the four positions: above, below, to the left, and to the right of the glyph. The default when not specified is "above". The placement respects the spacing specified by the `diacriticSpace` key in characters.json.
Configuration menu - View commit details
-
Copy full SHA for 0533aa0 - Browse repository at this point
Copy the full SHA 0533aa0View commit details -
generate: add support for multiple diacritics on a single glyph
This allows to define a glyph with multiple diacritics attached. Currently overlaps are not handled (spacing is currently shared for all of them), meaning stacking diacritics in the same direction is not possible.
Configuration menu - View commit details
-
Copy full SHA for b3870ba - Browse repository at this point
Copy the full SHA b3870baView commit details -
metadata: add various missing glyphs for Vietnamese
This adds various missing glyphs for Vietnamese. Note that some characters require multiple diacritics in different positions. There is a hack in diacritics.json to force monocraft.py to include many glyphs in the generation step. For example, the glyph "LATIN SMALL LETTER A WITH CIRCUMFLEX AND DOT BELOW" contain two diacritics `circumflex` and `dot_below`. generate_diacritics.py parses this as containing one diacritic: `circumflex_and_dot_below`, which it will not find in diacritics.json without this hack, and thus the glyph will not be generated. For a proper fix, the logic to determine which diacritics should be considered (lines 37-38, generate_diacritics.py) should be fixed to consult the list in characters.json instead.
Configuration menu - View commit details
-
Copy full SHA for e257b9b - Browse repository at this point
Copy the full SHA e257b9bView commit details -
generate: add support for offsetting the diacritic
This commit adds support for two optional keys in diacritics.json: offsetX and offsetY. This allows the glyph to be shifted relative to the base position.
Configuration menu - View commit details
-
Copy full SHA for a325aeb - Browse repository at this point
Copy the full SHA a325aebView commit details -
generate: raise glyph ascent height
Some Vietnamese glyphs are very tall with their diacritics, which causes the top of them to sometimes be cut off in some programs. This raises the font ascent by 1 pixel size to accomodate those glyphs. As a side effect, however, this also messes with font sizing in a lot of programs.
Configuration menu - View commit details
-
Copy full SHA for b81e925 - Browse repository at this point
Copy the full SHA b81e925View commit details -
Configuration menu - View commit details
-
Copy full SHA for 655dcff - Browse repository at this point
Copy the full SHA 655dcffView commit details -
glyph: change horn characters to be identical to Minecraft
The original variant looks better in text, but is different from the font in-game.
Configuration menu - View commit details
-
Copy full SHA for cd0fc82 - Browse repository at this point
Copy the full SHA cd0fc82View commit details -
diacritic: offset diacritics to be identical to Minecraft
The original variant looks better in text, but is different from the font in-game.
Configuration menu - View commit details
-
Copy full SHA for 40c1f92 - Browse repository at this point
Copy the full SHA 40c1f92View commit details
Commits on Feb 19, 2024
-
generate: bump ascent height for very taaaaall Vietnamese glyphs
The last size bump did not take into account capital letters.
Configuration menu - View commit details
-
Copy full SHA for b85f12b - Browse repository at this point
Copy the full SHA b85f12bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d9580be - Browse repository at this point
Copy the full SHA d9580beView commit details
Commits on Mar 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 49e3adc - Browse repository at this point
Copy the full SHA 49e3adcView commit details