Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wpewebkit: Bump to version 2.45.3 and add qt6 #506

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

wpewebkit: Bump to version 2.45.3 and add qt6 #506

wants to merge 2 commits into from

Conversation

Qingwu-Li
Copy link

Tested with QT6 build

Release notes:
https://wpewebkit.org/release/wpewebkit-2.44.3.html https://wpewebkit.org/release/wpewebkit-2.44.2.html

know issue：
gcc 11 may failed build neon.h failed for arm64, see Qingwu-Li/WebKit@176cb80

@Qingwu-Li
Copy link
Author

@pabelenda Please do a review!

@Qingwu-Li Qingwu-Li marked this pull request as ready for review September 6, 2024 09:19
@psaavedra
Copy link
Member

Hi @Qingwu-Li, thank you for the PR. We really appreciate all contributions to the project. I have a few comments regarding the pull request:

  • 2.45.x is not a stable WPE release. Odd-numbered versions refer to development releases. I suggest adjusting the wpewebkit bump to version 2.44.4. Please note that this PR already handles the bump to 2.44.4.
  • Is Qt6 WPE not yet supported in 2.44? If that is the case, we could consider adding support for 2.45 as an exception, but with DEFAULT_PREFERENCE = "-1" in the recipe.

@Qingwu-Li
wpewebkit: Bump-up to version 2.45.3
311523e 
Enable offscreen canvas by default.
Enable ImageBitmap acceleration.
Add support for accelerated offscreen canvas.
Do not display WebGL front buffer before it has been initialized.
Add a new setting to enable or disable the 2D canvas acceleration.
Add support for building QtWPE with Qt6.
Fix several crashes and rendering issues.

Release notes: https://wpewebkit.org/release/wpewebkit-2.45.3.html

Signed-off-by: LI Qingwu <[email protected]>
@Qingwu-Li
wpewebkit: add support for building QtWPE with Qt6
2aa0395 
Split Qt related configurations into separate files to support both
versions according value of LAYERSERIES_CORENAMES.

Signed-off-by: LI Qingwu <[email protected]>
@Qingwu-Li
Copy link
Author

  • Is Qt6 WPE not yet supported in 2.44? If that is the case, we could consider adding support for 2.45 as an exception, but with DEFAULT_PREFERENCE = "-1" in the recipe.

Hello @psaavedra , yes Qt6 WPE not supported in 2.44,
Change in V2:
Add DEFAULT_PREFERENCE = "-1"
Fix the gcc 11(kirkstone) build simd failed issue.

@aperezdc
Copy link
Member

We are going to release 2.46.0 soon. It would be great if you could update this PR with an update to that version when it's available in some weeks.

@psaavedra
Copy link
Member

We are going to release 2.46.0 soon. It would be great if you could update this PR with an update to that version when it's available in some weeks.

This PR (#509) will move the WPE version to 2.46. I could be very happy to integrate your changes after this 509 is merged if you make the adaptations in this 506 PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Qingwu-Li @psaavedra @aperezdc