Swap to Proc Macro Error 2 RUSTSEC-2024-0370 #350
Conversation
|
Please run the tests with |
|
ping @Keats |
|
Apparently the error messages between 1.79 and 1.81 are different. I've pushed the error messages for 1.79 since it seems thats what the CI test was failing on fist. However, one will always fail. This is true on the master branch as well. |
validator_derive/Cargo.toml
Outdated
| darling = { version = "0.20", features = ["suggestions"] } | ||
| once_cell = "1.18.0" | ||
|
|
||
| [features] | ||
| nightly = ["proc-macro-error2/nightly"] |
There was a problem hiding this comment.
can the name be more clear somehow?
There was a problem hiding this comment.
I'm not sure, I don't even know what this does in proc-macro-error2
There was a problem hiding this comment.
For the nightly feature in proc-macro-error2 its just a different implementation for emitting diagnostics and aborting. The main difference between the two appear to be that warnings are emitted in nightly while ignored in non-nightly builds. Tagging @HigherOrderLogic since they requested this.
I also think its fine if the feature isn't included since Validator might not want to use these extra warnings anyway. Might be a good idea to move this to a different PR for another discussion.
If you want to look at the code its here: https://github.com/GnomedDev/proc-macro-error-2/tree/master/src/imp
The delegate.rs is the nightly version and fallback.rs is the non nightly version
There was a problem hiding this comment.
I'm not sure, I don't even know what this does in proc-macro-error2
It's as @pvichivanives said, this feature enables emitting warning when using nightly compiler, otherwise ignored.
So to match the function, I think this feature can be renamed to nightly-warnning, or nightly-proc-macro, or even the longer nightly-proc-macro-error
Hi!
Given the RUSTSEC warning issued here: https://rustsec.org/advisories/RUSTSEC-2024-0370 just submitting a PR to move to the reccomended new version of procmacroerror2