Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ct: add ::ContinualTask to various adapter enums #29675

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

danhhz
Copy link
Contributor

@danhhz danhhz commented Sep 19, 2024

May as well rip off the band-aid and get it over with.

Touches #28899

Motivation

  • This PR adds a known-desirable feature.

Tips for reviewer

This is the first time I've had to make a change to the catalog protos, and I think I missed some steps :)

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

May as well rip off the band-aid and get it over with.
@danhhz danhhz requested review from a team as code owners September 19, 2024 20:24
@danhhz danhhz changed the title ct: add ::ContinualTask various adapter enums ct: add ::ContinualTask to various adapter enums Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant