Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: object is disabled after removeChild #381

Merged
merged 6 commits into from
Mar 21, 2024
Merged

fix: object is disabled after removeChild #381

merged 6 commits into from
Mar 21, 2024

Conversation

Codeboy-cn
Copy link
Collaborator

  • Fixed addChild and removeChild related

@Codeboy-cn Codeboy-cn added the bug Something isn't working label Mar 21, 2024
@Codeboy-cn Codeboy-cn added this to the 0.7 milestone Mar 21, 2024
@lslzl3000 lslzl3000 changed the title fix: addChild and removeChild related fix: object is disabled after removeChild Mar 21, 2024
@lslzl3000 lslzl3000 merged commit 51ff3ee into Orillusion:dev Mar 21, 2024
1 check passed
hellmor added a commit to hellmor/orillusion that referenced this pull request May 22, 2024
@hellmor
Squashed commit of the following:
7c3d6e0 
commit 590b213
Author: ShuangLiu <[email protected]>
Date:   Wed May 22 20:47:28 2024 +0800

    feat(buffer): return promise result

commit 4e05c04
Author: ShuangLiu <[email protected]>
Date:   Wed May 1 03:04:32 2024 +0800

    fix(picker): missing normal in pickFire

commit 1ab8718
Author: hellmor <[email protected]>
Date:   Thu Mar 21 20:36:23 2024 +0800

    fix: Error when lineJoin is set to round (Orillusion#366)

    * fix: Error when lineJoin is set to round

    Fix error when lineJoin is set to round.

    * fix: Remove eventListener.

    Remove the eventListener when transform is disposed.

commit 7ab2f48
Author: hellmor <[email protected]>
Date:   Thu Mar 21 20:35:36 2024 +0800

    fix: Solve the issues mentioned in Issue367 (Orillusion#368)

    Solve the issues mentioned in Issue367.

commit 51ff3ee
Author: Codeboy <[email protected]>
Date:   Thu Mar 21 20:35:09 2024 +0800

    fix: object is disabled after removeChild  (Orillusion#381)

    * chore: remove sample_candleflame maskMap

    * fix: addChild and removeChild related

    * chore: remove log

commit 65bda50
Author: ShuangLiu <[email protected]>
Date:   Wed Mar 13 03:59:02 2024 +0800

    fix(loaderFunctions): onUrl on loadGltf
lslzl3000 added a commit to hellmor/orillusion that referenced this pull request Jun 9, 2024
@lslzl3000
Squashed commit of the following:
562bea7 
commit 7c3d6e0
Author: hellmor <[email protected]>
Date:   Wed May 22 21:52:05 2024 +0800

    Squashed commit of the following:

    commit 590b213
    Author: ShuangLiu <[email protected]>
    Date:   Wed May 22 20:47:28 2024 +0800

        feat(buffer): return promise result

    commit 4e05c04
    Author: ShuangLiu <[email protected]>
    Date:   Wed May 1 03:04:32 2024 +0800

        fix(picker): missing normal in pickFire

    commit 1ab8718
    Author: hellmor <[email protected]>
    Date:   Thu Mar 21 20:36:23 2024 +0800

        fix: Error when lineJoin is set to round (Orillusion#366)

        * fix: Error when lineJoin is set to round

        Fix error when lineJoin is set to round.

        * fix: Remove eventListener.

        Remove the eventListener when transform is disposed.

    commit 7ab2f48
    Author: hellmor <[email protected]>
    Date:   Thu Mar 21 20:35:36 2024 +0800

        fix: Solve the issues mentioned in Issue367 (Orillusion#368)

        Solve the issues mentioned in Issue367.

    commit 51ff3ee
    Author: Codeboy <[email protected]>
    Date:   Thu Mar 21 20:35:09 2024 +0800

        fix: object is disabled after removeChild  (Orillusion#381)

        * chore: remove sample_candleflame maskMap

        * fix: addChild and removeChild related

        * chore: remove log

    commit 65bda50
    Author: ShuangLiu <[email protected]>
    Date:   Wed Mar 13 03:59:02 2024 +0800

        fix(loaderFunctions): onUrl on loadGltf

commit 40da2f1
Author: hellmor <[email protected]>
Date:   Tue May 21 22:44:58 2024 +0800

    feat: Collision Query

commit 77bff1c
Author: hellmor <[email protected]>
Date:   Sun May 12 21:46:56 2024 +0800

    Feat: SetPlane

commit 1984cd9
Author: hellmor <[email protected]>
Date:   Sun Apr 21 20:24:35 2024 +0800

    Feat: sample screen selection.

commit 28bfa40
Author: hellmor <[email protected]>
Date:   Sat Apr 6 10:09:11 2024 +0800

    multi view

commit 4349b0a
Author: hellmor <[email protected]>
Date:   Thu Apr 4 11:45:02 2024 +0800

    remove isReading

commit a63455e
Author: hellmor <[email protected]>
Date:   Thu Apr 4 11:36:23 2024 +0800

    slice controller

commit 84d0a7e
Author: hellmor <[email protected]>
Date:   Tue Apr 2 21:46:49 2024 +0800

    platform

commit a3a8e47
Author: hellmor <[email protected]>
Date:   Tue Mar 26 20:23:14 2024 +0800

    tooth
@lslzl3000 lslzl3000 mentioned this pull request Jul 10, 2024
Merged
lslzl3000 added a commit that referenced this pull request Jul 10, 2024
@lslzl3000
release v0.8
4902f04 
## [0.8.1](v0.7.2...v0.8.1) (2024-07-10)


### Bug Fixes

* **canvas:** fix external canvas resize on dpi change ([2e54053](2e54053))
* **effect:** fix grass get uniform data ([588721f](588721f))
* **effect:** update windSpeed ([538ec2d](538ec2d))
* Error when lineJoin is set to round ([#366](#366)) ([1ab8718](1ab8718))
* fix issue of [#387](#387) ([#394](#394)) ([6271c37](6271c37))
* **GlobalUniformGroup:** missing property for shadow camera ([1f90393](1f90393))
* **loaderFunctions:** onUrl on loadGltf ([65bda50](65bda50))
* object is disabled after removeChild  ([#381](#381)) ([51ff3ee](51ff3ee))
* **objparser:** loadObj crash [#372](#372) ([b3e9194](b3e9194))
* **picker:** missing normal in pickFire ([4e05c04](4e05c04))
* **pick:** fix normal in pickInfo ([5197317](5197317))
* Solve the issues mentioned in Issue367 ([#368](#368)) ([7ab2f48](7ab2f48))
* **transform:** fix wrong localRotQuat ([8c5e2b3](8c5e2b3))


### Features

* **Animator:** Unified skeleton animation and morph animation to AnimatorComponent ([#405](#405)) ([4cf51f3](4cf51f3))
* **buffer:** return promise result ([590b213](590b213))
* **GBuff:** compressed GBuff data. ([#412](#412)) ([4649add](4649add))
* **orbit:** pan at xz plane ([52383f5](52383f5))
* **sample:** add camera path animation sample ([#385](#385)) ([d447cd1](d447cd1))
* **sample:** add EatTheBox sample,add ShootTheBox sample ([#391](#391)) ([e925d1f](e925d1f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lslzl3000 lslzl3000 Awaiting requested review from lslzl3000

@X-OldGentleMan X-OldGentleMan Awaiting requested review from X-OldGentleMan

@hellmor hellmor Awaiting requested review from hellmor

Assignees
No one assigned
Labels
bug Something isn't working
Projects
Engine
Status: ✅ Done
Milestone
0.7
Development

Successfully merging this pull request may close these issues.
2 participants
@Codeboy-cn @lslzl3000