Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ally/registration #54

Open
wants to merge 19 commits into
base: dev-main
Choose a base branch
from
Open

Ally/registration #54

wants to merge 19 commits into from

Conversation

CloudF1sh
Copy link
Collaborator

I'm the real commit! The other is an imposter!

Still unable to connect with the database.

p.s. Thanks again Sal!

Scott-Larsen
Scott-Larsen approved these changes May 17, 2022
View reviewed changes
Copy link
Collaborator

@Scott-Larsen Scott-Larsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing sticks out to me as problematic although I may not know what's happening on every line of this code.

@SalMireles SalMireles changed the base branch from main to dev-main May 17, 2022 05:42
SalMireles
SalMireles requested changes May 17, 2022
View reviewed changes
Copy link
Collaborator

@SalMireles SalMireles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some initial feedback that needs to be addressed. Good stuff so far!

app/templates/404.html Show resolved Hide resolved
app/templates/login.html Outdated Show resolved Hide resolved
app/templates/register.html Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
app/templates/base.html Outdated Show resolved Hide resolved
app/routes.py Outdated Show resolved Hide resolved
@SalMireles
Copy link
Collaborator

SalMireles commented May 17, 2022 •
edited
Loading

The registration page loses the nav bar?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SalMireles SalMireles SalMireles requested changes

@Scott-Larsen Scott-Larsen Scott-Larsen approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CloudF1sh @SalMireles @Scott-Larsen