Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix WSPeer #458

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix WSPeer #458

wants to merge 1 commit into from

Conversation

dacapoday
Copy link

whether WSPeer inherits from Peer as well as RTCPeer?

whether WSPeer inherits from Peer as well as RTCPeer?
@fm-sys
Copy link
Contributor

fm-sys commented Jun 9, 2022

What additional value does this PR bring? It seems the inheritance is not necessary as it works without it as well...

@dacapoday
Copy link
Author

What additional value does this PR bring? It seems the inheritance is not necessary as it works without it as well...

I think this is a very hidden problem when fallback to websocket send msg and it can be reproduced

Steps to reproduce

  1. force snapdrop fallback to websocket by breakpoint and change window.isRtcSupported=false
    Snipaste_2022-06-09_23-42-29

  2. then send msg and file failed and console raise error
    Snipaste_2022-06-09_23-43-17

This error means WSPeer not properly initialized. Its really only have _send method!!

@fm-sys
Copy link
Contributor

fm-sys commented Jun 9, 2022

Ah, ok. Thanks for clarification and for helping to improve Snapdrop!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants