Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for mscz thubmnails #366

Open
wants to merge 5 commits into
base: Alpha-v9.4
Choose a base branch
from

Conversation

Joshua-Beatty
Copy link

Adds support for mscz thumbnails. Closes #363
image
Some of the older mscz I found don't have a thumbnail file so I default to the regular image.

This zip file has some example mscz files, 2 with thumbnails, one without.
MSCZ Examples.zip

@CyanVoxel CyanVoxel added Type: Enhancement New feature or request Type: UI/UX User interface and/or user experience Status: Review Needed A review of this is needed labels Aug 22, 2024
@CyanVoxel CyanVoxel added this to the Alpha 9.5 milestone Aug 23, 2024
@CyanVoxel
Copy link
Member

New thumbnail work is currently getting pointed to the thumbnails branch, which includes a host of new refactors for how extensions are handled and how the render methods are structured. To follow the pattern over there, this code would be put into it's own method while the MSCZ extension would be included in a new MediaType, MediaTypeCategory, etc. (Note: Not sure if this might count as an OpenDocument format?) There's a lot of precedent for the patterns over there to help guide you, but if you have any questions feel free to ask. Also while I haven't documented this anywhere yet, I'm trying to keep the MediaType lists and these render methods in alphabetical order.

Besides that, I appreciate the work on the feature! Cool to see new thumbnail support, especially when it just relies on the Python Standard Library!

@CyanVoxel CyanVoxel added Status: Changes Requested Changes are quested to this and removed Status: Review Needed A review of this is needed labels Aug 24, 2024
@CyanVoxel CyanVoxel changed the base branch from main to Alpha-v9.4 September 15, 2024 08:05
@CyanVoxel
Copy link
Member

I'm moved this PR from the deprecated thumbnails branch to Alpha-v9.4, which is the branch that thumbnails was eventually merged into. However the v9.4.x releases are now feature frozen and are now solely reserved for bugfixes. This means that after the changes from thumbnails are ported to main that I'll once again be moving the target for this PR over to there as a v9.5 feature.

Sorry for the disruption, and thank you for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Changes Requested Changes are quested to this Type: Enhancement New feature or request Type: UI/UX User interface and/or user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add preview for .mscz sheet music
2 participants