feat: Support custom user colors in tags #372
Draft
+127
−362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converts the tag color system to be based around a hex value rather than a named color system. This allows users to use any color they want for a tag, implemented via QColorDialog. Accent colors are then created at runtime for borders and text, etc.
When loading a library that contains the old named colors, the program will now automatically convert those to the hex value matching the old primary key. This will persist the new hex value when saved.
The predefined pallete colors are no longer necessary and were not being used anywhere, allowing them to be simply removed.
|
Marked as draft until #332 is merged, and I can update the stuff around it |
CyanVoxel
added
Type: Enhancement
|
We discussed it in the Discord already, but I'll repost my take on this here to keep everything in one place: [...] I've intended custom tag colors to still have a name associated with them, so they would be proper objects with an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hex-based colors
In order to support custom colors, tags must be moved away from the fixed name color system and are instead transitioned to a single primary hex value. All other accents are now up to the front-end to generate (if they are necessary). This allows for the removal of the large tag color dictionary, though the key and primary color hex remain for legacy purporses. A check is added to library loading to replace old fixed-named colors with their primary hex key.
Custom colors
QT provides an os-native color picker dialog complete with a full color spectrum, default colors, saving of colors, and an eye-dropper utility. The old color dropdown has been replaced with a push button that opens the color dialog modal and updates to reflect the selected color. The QColor class is also used for generating accent colors as it provides simple helper functions to create off-set colors.
closes #264