Skip to content

Commit

Permalink
Fix backend complier warnings (#1473)
Browse files Browse the repository at this point in the history
As title.

Co-authored-by: Yicong Huang <[email protected]>
  • Loading branch information
shengquan-ni and Yicong-Huang committed Mar 16, 2022
1 parent cc1af97 commit c103a3c
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ trait SkewDetectionHandler {
workflowReshapeState.detectionCallCount += 1

workflow.getAllOperators.foreach(opConfig => {
if (opConfig.isInstanceOf[HashJoinOpExecConfig[Any]]) {
if (opConfig.isInstanceOf[HashJoinOpExecConfig[_]]) {
// Skew handling is only for hash-join operator for now.
// 1: Find the skewed and helper worker that need first phase.
val skewedAndHelperPairsForFirstPhase =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import edu.uci.ics.amber.engine.common.rpc.AsyncRPCClient.{ControlInvocation, Re
import edu.uci.ics.amber.engine.common.rpc.AsyncRPCServer.ControlCommand

import scala.collection.mutable
import scala.util.Success

// TODO: Rename or refactor it since it has mixed duties (send/receive messages, execute callbacks)
private[client] object ClientActor {
Expand All @@ -37,7 +38,7 @@ private[client] class ClientActor extends Actor {
case InitializeRequest(workflow, controllerConfig) =>
assert(controller == null)
controller = context.actorOf(Controller.props(workflow, controllerConfig))
sender ! ()
sender ! Unit
case ClosureRequest(closure) =>
try {
sender ! closure()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ abstract class SQLSourceOpExec(
if (resultSet.next()) {

// manually skip until the offset position in order to adapt to progressive batches
curOffset.fold()(offset => {
curOffset.foreach(offset => {
if (offset > 0) {
curOffset = Option(offset - 1)
break
Expand All @@ -104,7 +104,7 @@ abstract class SQLSourceOpExec(
break

// update the limit in order to adapt to progressive batches
curLimit.fold()(limit => {
curLimit.foreach(limit => {
if (limit > 0) {
curLimit = Option(limit - 1)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ class AsterixDBSourceOpExec private[asterixdb] (
if (resultSet.hasNext) {

// manually skip until the offset position in order to adapt to progressive batches
curOffset.fold()(offset => {
curOffset.foreach(offset => {
if (offset > 0) {
curOffset = Option(offset - 1)
break
Expand All @@ -113,7 +113,7 @@ class AsterixDBSourceOpExec private[asterixdb] (
break

// update the limit in order to adapt to progressive batches
curLimit.fold()(limit => {
curLimit.foreach(limit => {
if (limit > 0) {
curLimit = Option(limit - 1)
}
Expand Down

0 comments on commit c103a3c

Please sign in to comment.