Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(linter): add TypeScript error check to package.json and pre-push hook #460

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andretchen0
Copy link
Contributor

Problem

TypeScript errors are not caught by Cientos' current pre-push hook. This has led to an accumulation of TypeScript errors in the codebase over time.

Solution

  • Add pnpm lint:ts to print out a list of TypeScript errors
  • Move current pnpm lint to pnpm lint:eslint
  • Modify pnpm lint to check for TypeScript errors
  • Add TypeScript error check in Husky pre-push hook and – by default – abort push if errors are present.

Copy link

stackblitz bot commented Aug 1, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for cientos-tresjs failed.

Name Link
🔨 Latest commit c2680ae
🔍 Latest deploy log https://app.netlify.com/sites/cientos-tresjs/deploys/66ab9d054b0afc0008569e2b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant