Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem matchers: Matches of test failures #422

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

WillAbides
Copy link

Description:

Currently test failures do not get annotated because the problem matcher requires that a column number be present, but go's test output does not include a column for test failures.

An example line that gets missed by the current matcher is:

/path/to/main_test.go:13: expected true but got false

The updated matcher makes the column number optional and matches the line above.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@WillAbides WillAbides requested a review from a team as a code owner September 13, 2023 18:10
@dsame dsame self-assigned this Sep 18, 2023
@dsame
Copy link
Contributor

dsame commented Sep 18, 2023

Hello @WillAbides , we are starting to review the PR

@WillAbides
Copy link
Author

You might want to hold off on this one for a bit. I used this same strategy in another action and got this report about it.

This pattern also matches test log statements, so those are getting annotated as failures even when the test passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants