Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Skinned Mesh Enablement Animation #1173

Merged
merged 15 commits into from
Sep 18, 2024
Merged

Conversation

anatawa12
Copy link
Owner

Fixes #894

@anatawa12 anatawa12 marked this pull request as ready for review September 1, 2024 17:03
.docs/content/docs/reference/merge-skinned-mesh/index.md Outdated Show resolved Hide resolved
.docs/content/docs/reference/merge-skinned-mesh/index.md Outdated Show resolved Hide resolved

このチェックボックスがオンの場合、統合対象のSkinnedMeshRendererの有効無効状態に関するアニメーションが統合先のSkinnedMeshRendererにコピーされます。

この機能は、統合先のSkinnedMeshRendererの`enabled`プロパティや、そのGameObjectや祖先のGameObjectの`activeSelf`プロパティのアニメーションをコピーします。
Copy link
Sponsor Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
この機能は、統合先のSkinnedMeshRendererの`enabled`プロパティや、そのGameObjectや祖先のGameObjectの`activeSelf`プロパティのアニメーションをコピーします
この機能は、統合先のSkinnedMeshRendererの`enabled`プロパティ(コンポーネントの有効無効)や、そのGameObjectや祖先のGameObjectの`activeSelf`プロパティ(GameObjectの有効無効)のアニメーションをコピーします

丁寧説明ver
お好みで

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

referenceはどっちかというとある程度分かる人想定なんですよね難しいところ

Copy link
Sponsor Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改変出来る程度に分かることと、Unityの変数が分かる(スクリプトが読める/書ける)のとはちょっと別だからにゃ…

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

animatorでenabledとかactiveとかは出てくるのよね...うーむ

Copy link
Sponsor Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

まあ、"SkinnedMeshRendererの"とか"GameObjectの"とか書いてあるので比較的分かりやすい方ではあると思われ

.docs/content/docs/reference/merge-skinned-mesh/index.md Outdated Show resolved Hide resolved
CHANGELOG-PRERELEASE.md Outdated Show resolved Hide resolved
CHANGELOG-PRERELEASE.md Outdated Show resolved Hide resolved
CHANGELOG-PRERELEASE.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved

このチェックボックスがオンの場合、統合対象のSkinnedMeshRendererの有効無効状態に関するアニメーションが統合先のSkinnedMeshRendererにコピーされます。

この機能は、統合先のSkinnedMeshRendererの`enabled`プロパティや、そのGameObjectや祖先のGameObjectの`activeSelf`プロパティのアニメーションをコピーします。
Copy link
Sponsor Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改変出来る程度に分かることと、Unityの変数が分かる(スクリプトが読める/書ける)のとはちょっと別だからにゃ…

.docs/content/docs/reference/merge-skinned-mesh/index.md Outdated Show resolved Hide resolved
.docs/content/docs/reference/merge-skinned-mesh/index.md Outdated Show resolved Hide resolved
.docs/content/docs/reference/merge-skinned-mesh/index.md Outdated Show resolved Hide resolved
CHANGELOG-PRERELEASE.md Outdated Show resolved Hide resolved
CHANGELOG-PRERELEASE.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@Sayamame-beans
Copy link
Sponsor Collaborator

the others are ok

@anatawa12 anatawa12 merged commit d940f30 into master Sep 18, 2024
6 checks passed
@anatawa12 anatawa12 deleted the merge-smr-enable-animation branch September 18, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants