Implement customization point for enqueue
#190
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Motivation The default implementation of `SerialExecutor` for `EventLoop`s causes a lot of allocations that's why we added a new customization point to allow `EventLoop`s to implement fast paths. # Modification This PR adds the customization point to `NIOTSEventLoop`.
FranzBusch
commented
Oct 9, 2023
| extension NIOTSEventLoop: NIOSerialEventLoopExecutor { | ||
| func enqueue(_ job: consuming ExecutorJob) { | ||
| let unownedJob = UnownedJob(job) | ||
| if let executorQueue = self.taskQueue as? _DispatchSerialExecutorQueue { |
There was a problem hiding this comment.
This is currently just available as underscored API and cannot be relied on. This PR is more for demonstrating that this can be fast pathed as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The default implementation of
SerialExecutorforEventLoops causes a lot of allocations that's why we added a new customization point to allowEventLoops to implement fast paths.Modification
This PR adds the customization point to
NIOTSEventLoop.