Provide resolution hints in case of possible local name conflicts #7505
Conversation
| @@ -539,6 +538,14 @@ impl PubGrubReportFormatter<'_> { | |||
| incomplete_packages, | |||
| output_hints, | |||
| ); | |||
|
|
|||
| // Check for no versions on the local packages themself, which may | |||
There was a problem hiding this comment.
Ugh, this logic is too weak and gets tricked into false positives, I think from the root itself appearing as a normal package down the chain even on other kind of failures.
I think I need to enhance this heuristic in order to detect the cycle.
lucab
force-pushed
the
ups/resolver-dependency-cycle
branch
from
4283b10
to
8c7bc4f
Compare
| /// | ||
| /// This shouldn't usually happen, but it could be the symptom of a naming | ||
| /// conflict with a transitive dependency existing on the index. | ||
| fn local_cycle_hint( |
There was a problem hiding this comment.
Unfortunately this heuristic doesn't work for the invocation in the original report (I tested by dropping the pin from your test). Maybe this would be helped by transforming the tree in as tracked by #7524 but I'm not sure. It looks like it might just be a bug because the tree does still contain a cycle with the same structure.
Have you used the UV_INTERNAL__SHOW_DERIVATION_TREE=1 utility? It can be helpful to display the tree in it's raw form.
Without a version pin:
Resolver derivation tree after reduction
dagster==0.0.0 depends on dagster-webserver*
dagster-webserver==1.8.7 depends on dagster==1.8.7
... an enumeration of all the versions follows
With a version pin:
Resolver derivation tree before reduction
root==0a0.dev0 depends on dagster*
dagster==0.0.0 depends on dagster-webserver==1.6.13
dagster-webserver==1.6.13 depends on dagster==1.6.13
no versions of dagster<0.0.0 | >0.0.0
Resolver derivation tree after reduction
dagster==0.0.0 depends on dagster-webserver==1.6.13
dagster-webserver==1.6.13 depends on dagster==1.6.13
On a separate note, it's pretty hard to understand what this heuristic is doing. I know you plan to do some polish on it, and it's not your fault that the data structure is complicated, but I can't review it without some additional context on the idea.
This enhances the hints generator in the resolver with some heuristic to detect and warn in case of failures due version mismatched on a local package. Those may be the symptom of name conflict/shadowing with a transitive dependency.
lucab
force-pushed
the
ups/resolver-dependency-cycle
branch
from
8c7bc4f
to
842f039
Compare
lucab
force-pushed
the
ups/resolver-dependency-cycle
branch
from
842f039
to
0defe6e
Compare
This enhances the hints generator in the resolver with some heuristic to detect and warn in case of failures due to version mismatches on a local package. Those may be the symptom of name conflict/shadowing with a transitive dependency.
Closes: #7329