Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added first workflow #88

Merged
merged 6 commits into from
Oct 12, 2021
Merged

Conversation

KhudaDad414
Copy link
Member

@KhudaDad414 KhudaDad414 commented Oct 8, 2021

Description

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KhudaDad414 I left some comments. Looks good so far, just minor stuff

long term, once these calls are expensive we at least have a custom code we can influence and setup a kind of persistence, where we share information about contributors and can check with the API if user is on the list or not.

.github/workflows/first-interaction.yaml Outdated Show resolved Hide resolved
.github/workflows/first-interaction.yaml Outdated Show resolved Hide resolved
.github/workflows/first-interaction.yaml Outdated Show resolved Hide resolved
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just think that this workflow should be added here and we should not add a new file

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff mate, great contribution as usual 🚀
Now merge and let us see how it works in action 🤞🏼 😄

@derberg derberg merged commit 4533698 into asyncapi:master Oct 12, 2021
@KhudaDad414 KhudaDad414 deleted the first-interaction branch February 9, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove welcome workflow and replace with something custom
2 participants