Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add board support for Arduino MKR WiFi 1010. #606

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Foosvald
Copy link

@Foosvald Foosvald commented May 4, 2022

Summary

This adds initial board support for the Arduino MKR WiFi 1010 board.

(This is my first PR here and I'm also pretty new to both embedded and Rust, so I hope I've done everything correctly. And I would be happy to fix anything according to your feedback!)

The wifi_nina library hasn't been updated in a while so I currently use my fork of it until (or if) dflemstr/wifi-nina#6 is merged upstream.
.

Checklist

  • CHANGELOG.md for the BSP or HAL updated
  • All new or modified code is well documented, especially public items
  • No new warnings or clippy suggestions have been introduced (see CI or check locally)

If Adding a new Board

  • Board CI added to crates.json
  • Board is properly following "Tier 2" conventions, unless otherwise decided to be "Tier 1"

@jbeaurivage
Copy link
Contributor

Hi! Thanks for the PR. I would suggest porting this to atsamd-hal 0.15 if you wish. This effort would help up keep our Tier 2 BSPs fresh!

@Foosvald
Copy link
Author

Foosvald commented May 4, 2022

Hi! Thanks for the PR. I would suggest porting this to atsamd-hal 0.15 if you wish. This effort would help up keep our Tier 2 BSPs fresh!

Absolutely, good idea! I'll do it and push an update :)

panic-halt = "0.2"
panic-semihosting = "0.5"
usbd-serial = "0.1"
wifi-nina = { git = "https://github.com/Foosvald/wifi-nina", branch = "invert-reset-logic-with-feature", features = ["reset-high"] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you managed to get your changes upstreamed? I don't really like depending on someone's personal branch. That feels very hacky. Plus, I don't think you can even publish to crates.io if you have a Git dependency.

@bradleyharden
Copy link
Contributor

@Foosvald, I think this looks good. The Git dependency is the only show stopper.

Have you tested all your examples?

@jbeaurivage jbeaurivage added the board support Related to support for a particular board label May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
board support Related to support for a particular board
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants