fix(registry): treat null claim value as missing #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
=======================================
Coverage 99.80% 99.80%
=======================================
Files 44 44
Lines 2548 2548
Branches 371 309 -62
=======================================
Hits 2543 2543
Misses 1 1
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Assert the following to be true:
essential allow_blank value result
True False missing MissingClaimError
True False null MissingClaimError
True False "" InvalidClaimError
True False "x" Accepted
True True missing MissingClaimError
True True null MissingClaimError
True True "" Accepted
True True "x" Accepted
Code:
def test_essential_empty_value(self):
claims_requests = jwt.JWTClaimsRegistry(sub={"essential": True})
self.assertRaises(MissingClaimError, claims_requests.validate, {"sub": None})
Signed-off-by: Alon Bar-Lev <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
lepture
approved these changes
Oct 6, 2023
lepture
approved these changes
Oct 6, 2023
| raise MissingClaimError(",".join(missed_key)) | ||
| missed_keys = {key for key in self.essential_keys if claims.get(key) is None} | ||
| if missed_keys: | ||
| raise MissingClaimError(",".join(sorted(missed_keys))) |
There was a problem hiding this comment.
Do we need to sort keys here? I'm ok with the sorting. But is there a reason?
There was a problem hiding this comment.
This is human readable message, it should be deterministic. As set order is not deterministic we should sort it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assert the following to be true:
Code:
@lepture : please tell me if you want to treat this as MissingClaimError or InvalidClaimError, I believe that JSON null value should be treated as missing.