Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tr-trimmer #50775

Merged
merged 8 commits into from
Sep 19, 2024
Merged

Add tr-trimmer #50775

merged 8 commits into from
Sep 19, 2024

Conversation

apcamargo
Copy link
Contributor

This PR adds tr-trimmer, a tool for identification and trimming of terminal repeats in sequences within FASTA files.


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@apcamargo
Copy link
Contributor Author

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Sep 18, 2024
Copy link
Contributor

@mbhall88 mbhall88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the other PR, I would suggest also doing this https://conda-forge.org/docs/maintainer/adding_pkgs/#rust. re: #50800

recipes/tr-trimmer/build.sh Outdated Show resolved Hide resolved
@mbhall88
Copy link
Contributor

See #50776 (comment)

Sorry for this @apcamargo you're something of a guinea pig here haha. I am trying to get our Rust practices inline with the Rust packages on conda-forge. (And I need to update my bioconda Rust packages too)

@apcamargo
Copy link
Contributor Author

That's ok! It was actually very stupid of me to do that

Co-authored-by: Michael Hall <[email protected]>
@mbhall88
Copy link
Contributor

mbhall88 commented Sep 19, 2024

Thanks for your patience @apcamargo. We got there in the end. I think these repos will act as a great example for others adding/updating rust packages.

@mbhall88 mbhall88 merged commit 871f2a6 into bioconda:master Sep 19, 2024
6 checks passed
@apcamargo
Copy link
Contributor Author

Thanks, @mbhall88!

Do we have specific recommendations for maturing recipes?

@mbhall88
Copy link
Contributor

I created this issue #50800 to see if we can document all of this somewhere - or at least point to the conda-forge docs for the bundled licenses part. There is also an open issue here conda-forge/conda-forge.github.io#2191 about documenting the no-track option too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants