Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support to run build for recipes with linux-aarch64 additional-platforms #923

Merged
merged 5 commits into from
Oct 14, 2023
Merged

feat: add support to run build for recipes with linux-aarch64 additional-platforms #923

merged 5 commits into from
Oct 14, 2023

Conversation

Yikun
Copy link
Contributor

@Yikun Yikun commented Oct 9, 2023 •
edited
Loading

This patches add support in bioconda-utils to run on linux-arm if the following is added to the recipe:

extra:
  additional-platforms:
    - linux-aarch64
  • Add a check_native_platform_skippable to checkout should we skip the recipes in current nativei platform
  • Add extra_additional_platforms property to recipe object
  • Add UT to test above function
py.test --durations=0 test/test_utils.py::test_native_platform_skipping
py.test --durations=0 test/test_recipe.py::test_recipe_extra_additional_platforms
  • E2E test
bioconda-utils build recipes config.yml --git-range origin/master HEAD
bioconda-utils build recipes config.yml --git-range origin/master HEAD --force
  • Fix test trigger by adding fetch-depth

related: bioconda/bioconda-recipes#40550

@Yikun Yikun mentioned this pull request Oct 9, 2023
Merged
7 tasks
martin-g
martin-g approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@martin-g martin-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yikun Yikun changed the title feat: add support to run build for recipes with additional-platforms feat: add support to run build for recipes with linux-aarch64 additional-platforms Oct 9, 2023
johanneskoester
johanneskoester requested changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@johanneskoester johanneskoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! Would you mind adding a test case?

@Yikun Yikun force-pushed the addition branch 2 times, most recently from 2f9dfb5 to 5e23104 Compare October 13, 2023 07:57
@Yikun
Add unit test
3c68c8d 
Signed-off-by: Yikun Jiang <[email protected]>
johanneskoester
johanneskoester requested changes Oct 13, 2023
View reviewed changes
bioconda_utils/build.py Outdated Show resolved Hide resolved
bioconda_utils/build.py Outdated Show resolved Hide resolved
@Yikun
Address comments
046dbbf 
Signed-off-by: Yikun Jiang <[email protected]>
@johanneskoester johanneskoester merged commit 55671f7 into bioconda:master Oct 14, 2023
9 checks passed
johanneskoester pushed a commit that referenced this pull request Oct 14, 2023
@github-actions
chore: release 2.7.0 (#926)
a0f6c7b 
🤖 I have created a release \*beep\* \*boop\*
---
##
[2.7.0](https://www.github.com/bioconda/bioconda-utils/compare/v2.6.0...v2.7.0)
(2023-10-14)


### Features

* add support to run build for recipes with linux-aarch64
additional-platforms
([#923](https://www.github.com/bioconda/bioconda-utils/issues/923))
([55671f7](https://www.github.com/bioconda/bioconda-utils/commit/55671f77124065fd09bb7d9c4a856cf0e87e48a4))
---


This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@Yikun Yikun mentioned this pull request Nov 15, 2023
Merged
5 tasks
@martin-g martin-g mentioned this pull request Feb 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-g martin-g martin-g approved these changes

@johanneskoester johanneskoester johanneskoester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yikun @martin-g @johanneskoester