Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Private database provider #29

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vikas0380
Copy link

Description: Added an option to add the local or private MySQL and Postgres SQL database provider.

Changes: If the environment variable NEXT_PUBLIC_DB_PROVIDER is not specified, the default provider will be set to private.

Copy link

trunk-io bot commented Apr 15, 2024

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

Copy link

vercel bot commented Apr 15, 2024

@vikas0380 is attempting to deploy a commit to the Nazarii Korniienko's projects Team on Vercel.

A member of the Team first needs to authorize it.

@wanghaisheng
Copy link

@vikas0380 can you add sqlite support

@blefnk blefnk self-assigned this May 15, 2024
@blefnk blefnk added the enhancement New feature or request label May 15, 2024
@blefnk blefnk added this to the v1-v2 milestone May 15, 2024
@blefnk blefnk changed the title Private database provider ✅ Private database provider May 15, 2024
@blefnk
Copy link
Owner

blefnk commented May 15, 2024

Hello and welcome, @wanghaisheng! I am already working on rewriting the project for better-sqlite3. I tried to do this a long time ago, but I had some difficulties then. I think now I have a better chance of success. This will be delivered in Relivator 1.2.6 or 1.3.0. Thank you for your interest in the project and for your patience!

@blefnk
Copy link
Owner

blefnk commented May 15, 2024

@vikas0380 Hi! Thank you very much for your contribution and I apologize for the late reply! I've integrated your PR into the next 1.2.6 version and also adapted it accordingly to the changes mentioned in issue #32. And also, possibly but idk, since I'm working on adding SQLite, it doesn't require any additional installations unlike Postgres/MySQL, so maybe I'll set SQLite as the default provider once it is fully delivered. upd. As an option, SQLite will be default, but it will be possible to switch to Postgres manually by commenting out specific lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants