Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🦦 Updated to 1.20.1 (for real this time) #59

Open
wants to merge 8 commits into
base: 1.20.1
Choose a base branch
from

Conversation

PandaLunatique
Copy link

  • Updated to Geckolib 4
  • Updated models, entities and renderers to work with Geckolib 4 and Forge 1.20.1
  • Added dedicated class for biome modifiers generator CACBiomeModifier
  • Updated pack to pack_format 15 and builtin too
  • And basically updated everything to work with 1.20.1 api changes

Hi! Nice to meet you!
Im currently making a modded minecraft server 1.20.1 for me and friends for the summer and I really wanted to use you mod but I realized it wasn't available for 1.20.1 so I decided to make a quick update to make it work on my server. So if you're interested, here is my updated version!
Warm regards,

Pandalunatique.

- Updated to Geckolib 4
- Updated models, entities and renderers to work with Geckolib 4 and Forge 1.20.1
- Added dedicated class for biome modifiers generator CACBiomeModifier
- Updated pack to pack_format 15 and builtin too
- And basically updated everything to work with 1.20.1 api changes
@PandaLunatique
Copy link
Author

Closes #44

@MeixDev
Copy link

MeixDev commented Feb 28, 2024

Hey! Good job on updating the mod.

The Otter model seems to have a few issues with the update. Items held by Otters are a lot bigger than they should usually be (Let an Otter kill a Koi Fish to see it for example), and the model sometimes blinks. A few other times I had the head disappear or blink repeatedly too.

Every other model is fine from what I could test.

I tested in both a heavily modded environment, and in a clean 1.20.1 Forge 47.2.17 with only Geckolib 4.4.2 and your fork of Creatures & Critters.
I would not be surprised if it came from my environment somehow. It's my first time building a Forge mod.

@PandaLunatique
Copy link
Author

Hey! Good job on updating the mod.

The Otter model seems to have a few issues with the update. Items held by Otters are a lot bigger than they should usually be (Let an Otter kill a Koi Fish to see it for example), and the model sometimes blinks. A few other times I had the head disappear or blink repeatedly too.

Every other model is fine from what I could test.

I tested in both a heavily modded environment, and in a clean 1.20.1 Forge 47.2.17 with only Geckolib 4.4.2 and your fork of Creatures & Critters. I would not be surprised if it came from my environment somehow. It's my first time building a Forge mod.

Indeed, I do have the same issue, I should have time to fix it by tomorrow ! Thank you for letting me know about this problem.

@PandaLunatique
Copy link
Author

Here is a quick fix for model size, I will later try to fix the positionning for the items.

@Clausioporosis
Copy link

Mind sharing the Jar file or telling me how to build it?

@PandaLunatique
Copy link
Author

Mind sharing the Jar file or telling me how to build it?

Sure! What version are you planning to play on ?

@Clausioporosis
Copy link

Thanks a lot :) I'm playing on 1.20.1.

@PandaLunatique
Copy link
Author

Thanks a lot :) I'm playing on 1.20.1.

Here you go!
crittersandcompanions-1.20.1-2.1.1.zip
(Jar SHA1- : 66dd8e0719d11227d49c1f017a8452604800a53c)

@Clausioporosis
Copy link

Oh, I forgot to say that I'm playing on fabric.. Still possible?
Thank you nonetheless.

@PandaLunatique
Copy link
Author

Oh, I forgot to say that I'm playing on fabric.. Still possible? Thank you nonetheless.

I haven't made a port for Fabric yet, sorry!

@steelfoot
Copy link

Thanks a lot :) I'm playing on 1.20.1.

Here you go! crittersandcompanions-1.20.1-2.1.1.zip (Jar SHA1- : 66dd8e0719d11227d49c1f017a8452604800a53c)

Hey, I hate to ask for such a dumb fix, but Forge and NeoForged use different version numbering systems for compatible modloaders and this thinks that NeoForged's version is older because it uses 47.1 with a bigger revision number instead of 47.2 with a smaller one. Is there a way this can be updated to be compatible with NeoForged 47.1.107? I tried modifying the line of code for the dependency in build.gradle and apparently that's not the solution so I'm stumped. Thanks!

@Lilyp3892 Lilyp3892 mentioned this pull request May 2, 2024
@Handrail9
Copy link

Handrail9 commented May 3, 2024

Thanks a lot :) I'm playing on 1.20.1.

Here you go! crittersandcompanions-1.20.1-2.1.1.zip (Jar SHA1- : 66dd8e0719d11227d49c1f017a8452604800a53c)

Is there a way this can be updated to be compatible with NeoForged 47.1.107?

I want to confirm that this is still an issue on the official release as per #60 . Neoforge doesn't work for this mod and it appears main forge doesn't work for servers.

@PandaLunatique
Copy link
Author

Thanks a lot :) I'm playing on 1.20.1.

Here you go! crittersandcompanions-1.20.1-2.1.1.zip (Jar SHA1- : 66dd8e0719d11227d49c1f017a8452604800a53c)

Hey, I hate to ask for such a dumb fix, but Forge and NeoForged use different version numbering systems for compatible modloaders and this thinks that NeoForged's version is older because it uses 47.1 with a bigger revision number instead of 47.2 with a smaller one. Is there a way this can be updated to be compatible with NeoForged 47.1.107? I tried modifying the line of code for the dependency in build.gradle and apparently that's not the solution so I'm stumped. Thanks!

Hi! Indeed, I'll try to find some time and send you a working NeoForge version next week.

@steelfoot
Copy link

Thanks a lot :) I'm playing on 1.20.1.

Here you go! crittersandcompanions-1.20.1-2.1.1.zip (Jar SHA1- : 66dd8e0719d11227d49c1f017a8452604800a53c)

Hey, I hate to ask for such a dumb fix, but Forge and NeoForged use different version numbering systems for compatible modloaders and this thinks that NeoForged's version is older because it uses 47.1 with a bigger revision number instead of 47.2 with a smaller one. Is there a way this can be updated to be compatible with NeoForged 47.1.107? I tried modifying the line of code for the dependency in build.gradle and apparently that's not the solution so I'm stumped. Thanks!

Hi! Indeed, I'll try to find some time and send you a working NeoForge version next week.

Hey, thanks in advance! I appreciate it!

@PandaLunatique
Copy link
Author

Thanks a lot :) I'm playing on 1.20.1.

Here you go! crittersandcompanions-1.20.1-2.1.1.zip (Jar SHA1- : 66dd8e0719d11227d49c1f017a8452604800a53c)

Hey, I hate to ask for such a dumb fix, but Forge and NeoForged use different version numbering systems for compatible modloaders and this thinks that NeoForged's version is older because it uses 47.1 with a bigger revision number instead of 47.2 with a smaller one. Is there a way this can be updated to be compatible with NeoForged 47.1.107? I tried modifying the line of code for the dependency in build.gradle and apparently that's not the solution so I'm stumped. Thanks!

Hi! Indeed, I'll try to find some time and send you a working NeoForge version next week.

Hey, thanks in advance! I appreciate it!
Apparently fixed in 07baeed

@PandaLunatique
Copy link
Author

Thanks a lot :) I'm playing on 1.20.1.

Here you go! crittersandcompanions-1.20.1-2.1.1.zip (Jar SHA1- : 66dd8e0719d11227d49c1f017a8452604800a53c)

Hey, I hate to ask for such a dumb fix, but Forge and NeoForged use different version numbering systems for compatible modloaders and this thinks that NeoForged's version is older because it uses 47.1 with a bigger revision number instead of 47.2 with a smaller one. Is there a way this can be updated to be compatible with NeoForged 47.1.107? I tried modifying the line of code for the dependency in build.gradle and apparently that's not the solution so I'm stumped. Thanks!

Hi! Indeed, I'll try to find some time and send you a working NeoForge version next week.

Hey, thanks in advance! I appreciate it!
Apparently fixed in 07baeed

Apparently still doesn't works so here is a rebuilt fixed version based on my fork that should work:tm: with neoforge
here : https://we.tl/t-MC6j4YIFjk

@steelfoot
Copy link

Thanks a lot :) I'm playing on 1.20.1.

Here you go! crittersandcompanions-1.20.1-2.1.1.zip (Jar SHA1- : 66dd8e0719d11227d49c1f017a8452604800a53c)

Hey, I hate to ask for such a dumb fix, but Forge and NeoForged use different version numbering systems for compatible modloaders and this thinks that NeoForged's version is older because it uses 47.1 with a bigger revision number instead of 47.2 with a smaller one. Is there a way this can be updated to be compatible with NeoForged 47.1.107? I tried modifying the line of code for the dependency in build.gradle and apparently that's not the solution so I'm stumped. Thanks!

Hi! Indeed, I'll try to find some time and send you a working NeoForge version next week.

Hey, thanks in advance! I appreciate it!
Apparently fixed in 07baeed

Apparently still doesn't works so here is a rebuilt fixed version based on my fork that should work:tm: with neoforge here : https://we.tl/t-MC6j4YIFjk

I can confirm that this works on servers. Thanks! Made the week of one of my players!

@PandaLunatique
Copy link
Author

Thanks a lot :) I'm playing on 1.20.1.

Here you go! crittersandcompanions-1.20.1-2.1.1.zip (Jar SHA1- : 66dd8e0719d11227d49c1f017a8452604800a53c)

Hey, I hate to ask for such a dumb fix, but Forge and NeoForged use different version numbering systems for compatible modloaders and this thinks that NeoForged's version is older because it uses 47.1 with a bigger revision number instead of 47.2 with a smaller one. Is there a way this can be updated to be compatible with NeoForged 47.1.107? I tried modifying the line of code for the dependency in build.gradle and apparently that's not the solution so I'm stumped. Thanks!

Hi! Indeed, I'll try to find some time and send you a working NeoForge version next week.

Hey, thanks in advance! I appreciate it!
Apparently fixed in 07baeed

Apparently still doesn't works so here is a rebuilt fixed version based on my fork that should work:tm: with neoforge here : https://we.tl/t-MC6j4YIFjk

I can confirm that this works on servers. Thanks! Made the week of one of my players!

No worries ! 😉
I hopefully fixed all null pointer exceptions but don't hesitate to let me know if you encounter any

@csm-kb
Copy link

csm-kb commented May 22, 2024

Hey! pray for me but I'm about to work towards getting the mod to build for Fabric 1.20.1, anything impeding this going in?

@PandaLunatique
Copy link
Author

Hey! pray for me but I'm about to work towards getting the mod to build for Fabric 1.20.1, anything impeding this going in?

Good luck to you! I don't think so, it actually shouldn't be that hard thanks to Geckolib's API which is fully compatible.
I don't know how fabric handle items and entity registries tho

@azerotj
Copy link

azerotj commented Jun 2, 2024

doesn't work for me for some reason. Items from the mod are not displayed in REI and in creative

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants