Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(focus): init #1209

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

IncognitoTGT
Copy link

@IncognitoTGT IncognitoTGT commented Aug 17, 2024

reopening of #1205 as I messed up the branch

🎉 Theme for Focus 🎉

Focus is a Student information System used by schools to manage student information, such as grades, classes, and enrollment.

💬 Additional Comments 💬

CSS classes are really weird and I ended up using a lot of !important, and I had to make an outline for the background to extend on the homepage.

Also, the preview image has things blurred as using the font did not apply everywhere, as the site's css uses !important way more than it should.

🗒 Checklist 🗒

  • I have read and followed Catppuccin's submission guidelines.
  • I have made a new directory underneath /styles/<name-of-website> containing the contents of the /template directory.
    • I have ensured that the new directory is in lower-kebab-case.
    • I have followed the template and kept the preprocessor as LESS.
  • I have made sure to update the
    userstyles.yml
    file with information about the new userstyle.
  • I have included the following files:
    • catppuccin.user.css - all the CSS for the userstyle, based on the
      template.
    • preview.webp - composite image of all four individual flavor screenshots (taken with the default accent color of mauve) stitched together, generated via Catwalk.

@IncognitoTGT IncognitoTGT requested a review from a team as a code owner August 17, 2024 00:16
@IncognitoTGT IncognitoTGT mentioned this pull request Aug 17, 2024
8 tasks
@uncenter uncenter marked this pull request as draft August 17, 2024 17:40
@IncognitoTGT
Copy link
Author

IncognitoTGT commented Aug 17, 2024

I think it's ready, i just missed a few lol

should be ready to merge now

@IncognitoTGT IncognitoTGT marked this pull request as ready for review August 17, 2024 18:15
isabelroses
isabelroses previously approved these changes Aug 24, 2024
Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't really test this but the CSS looks good

@uncenter
Copy link
Member

nice work

Did you test the UI?

@uncenter
Copy link
Member

Did you test the UI?

that was for the code

You need to say that when reviewing? Or just don't approve if you haven't tested the entire application.

styles/focus/catppuccin.user.css Show resolved Hide resolved
#userwayAccessibilityIcon {
img {
background-color: @blue !important;
border-radius: 50%;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this need to be set?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-08-24 at 10 38 24
this icon

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it look like with the userstyle not applied? Or with the userstyle applied but the border radius commented out?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not applied - default blue
Screenshot 2024-08-24 at 11 14 29

border radius removed = weird square border (i could probably use a filter for this tbh)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to work for some reason, even directly on the image element

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please stop resolving this thread of an ongoing conversation.

styles/focus/catppuccin.user.css Outdated Show resolved Hide resolved
@uhidontkno
Copy link

im banned from my school's auth portal so i cant test catppuccin focus 💀

@uhidontkno
Copy link

im literally the only other focus user

@uhidontkno
Copy link

uhidontkno commented Aug 25, 2024

looks good @IncognitoTGT but file uploads, and tables are broken
Screenshot_20240824-211418_1
Screenshot_20240824-211854_1

@uhidontkno
Copy link

uhidontkno commented Aug 25, 2024

oh also focus web pages are mostly unstyled.
image

@IncognitoTGT
Copy link
Author

IncognitoTGT commented Aug 25, 2024

looks good @IncognitoTGT but file uploads, and tables are broken Screenshot_20240824-211418_1 Screenshot_20240824-211854_1

I'll take a look at this one, the schedule table couldn't be styled no matter what I tried so I didn't touch that one.

oh also focus web pages are mostly unstyled. image

I don't have access to these, can you send me the markup tree or the css classes that need to be styled for this?

@uncenter uncenter added the pending Pending due to internal discussion, planned website updates, etc. label Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending Pending due to internal discussion, planned website updates, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants