Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(netscape): init #1235

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

NeonGamerBot-QK
Copy link
Member

@NeonGamerBot-QK NeonGamerBot-QK commented Aug 24, 2024

🎉 Theme for netscape 🎉

an old netscape site with news.

💬 Additional Comments 💬

images are currently unthemed and have no idea how to theme them atm.
Ill generate preview before merge.
Closes catppuccin/catppuccin#1841

🗒 Checklist 🗒

  • I have read and followed Catppuccin's submission guidelines.
  • I have made a new directory underneath /styles/<name-of-website> containing the contents of the /template directory.
    • I have ensured that the new directory is in lower-kebab-case.
    • I have followed the template and kept the preprocessor as LESS.
  • I have made sure to update the
    userstyles.yml
    file with information about the new userstyle.
  • I have included the following files:
    • catppuccin.user.css - all the CSS for the userstyle, based on the
      template.
    • preview.webp - composite image of all four individual flavor screenshots (taken with the default accent color of mauve) stitched together, generated via Catwalk.

@NeonGamerBot-QK NeonGamerBot-QK requested a review from a team as a code owner August 24, 2024 22:53
Copy link
Member

@uncenter uncenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments about metadata and extra comments, but in general with the main styling I'm seeing a lot of unorganized classes grouped together arbitrarily, and lots of selectors without comments that don't make it clear what they theme (e.g. #hdrLf). I'd recommend you look through existing userstyles to see how me and other authors/maintainers keep userstyles organized, be it top to bottom of the page (header, body, then footer), or by basic elements first and more specific stuff further down, etc.

scripts/userstyles.yml Outdated Show resolved Hide resolved
scripts/userstyles.yml Outdated Show resolved Hide resolved
styles/netscape/catppuccin.user.css Outdated Show resolved Hide resolved
styles/netscape/catppuccin.user.css Outdated Show resolved Hide resolved
@NeonGamerBot-QK
Copy link
Member Author

Some comments about metadata and extra comments, but in general with the main styling I'm seeing a lot of unorganized classes grouped together arbitrarily, and lots of selectors without comments that don't make it clear what they theme (e.g. #hdrLf). I'd recommend you look through existing userstyles to see how me and other authors/maintainers keep userstyles organized, be it top to bottom of the page (header, body, then footer), or by basic elements first and more specific stuff further down, etc.

i can try my best since i wrote half and then imported the other half. (also cause they are all short-worded classNames/ID's)

@uncenter
Copy link
Member

uncenter commented Aug 25, 2024

Make sure to update that metadata in the UsercCSS comment as well, with the name change.

@NeonGamerBot-QK

This comment was marked as off-topic.

Copy link
Member

@uncenter uncenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking very messy overall. Lots of random newlines separating content for no reason, commented out code, a lot of div.xyz for whatever reason - just use .xyz if it is clear by the classname/ID. Also please format it with Prettier (format on save is a godsend, use it).

@NeonGamerBot-QK
Copy link
Member Author

NeonGamerBot-QK commented Sep 6, 2024

ignore the review request it was a missclick
now its ready

@uncenter uncenter added the pending Pending due to internal discussion, planned website updates, etc. label Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending Pending due to internal discussion, planned website updates, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants