Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jisho): init #1264

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat(jisho): init #1264

wants to merge 9 commits into from

Conversation

Lichthagel
Copy link
Contributor

🎉 Theme for Jisho.org 🎉

Jisho is a powerful Japanese-English dictionary. It lets you find words, kanji, example sentences and more quickly and easily.

jisho-mocha

💬 Additional Comments 💬

There are some minor inconsistencies/inconveniences. See the included comments.

🗒 Checklist 🗒

  • I have read and followed Catppuccin's submission guidelines.
  • I have made a new directory underneath /styles/<name-of-website> containing the contents of the /template directory.
    • I have ensured that the new directory is in lower-kebab-case.
    • I have followed the template and kept the preprocessor as LESS.
  • I have made sure to update the
    userstyles.yml
    file with information about the new userstyle.
  • I have included the following files:
    • catppuccin.user.css - all the CSS for the userstyle, based on the
      template.
    • preview.webp - composite image of all four individual flavor screenshots (taken with the default accent color of mauve) stitched together, generated via Catwalk.

@Lichthagel Lichthagel requested a review from a team as a code owner September 5, 2024 10:49
isabelroses
isabelroses previously approved these changes Sep 5, 2024
Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this drop down the borders look a bit strange.
{B0D5ADE3-9CD3-4B68-9287-140CD1CEABE2}

Beyond that the website looks good

@isabelroses isabelroses dismissed their stale review September 5, 2024 11:18

sorry ment request changes

@Lichthagel
Copy link
Contributor Author

Lichthagel commented Sep 5, 2024

In this drop down the borders look a bit strange. {B0D5ADE3-9CD3-4B68-9287-140CD1CEABE2}

Beyond that the website looks good

There is some space between those elements:
grafik
("Leerraum" means "empty space")
They use margin: 0 -2px; to alleviate this, but this is rather inconsistent.

@Lichthagel
Copy link
Contributor Author

Lichthagel commented Sep 5, 2024

grafik

Using display: flex; and removing the margin, removes the gap and also shows the rounded corners, as is likely intended.
I did this change in 6772d95 (#1264).

isabelroses
isabelroses previously approved these changes Sep 11, 2024
Copy link
Member

@uncenter uncenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.text_input .selected unthemed (I drew a character and it made a character yellow in the search input?).

These links on https://jisho.org/search/%E5%88%A9%20%23kanji have an unthemed border bottom:
CleanShot 2024-09-14 at 20 47 09

scripts/userstyles.yml Outdated Show resolved Hide resolved
styles/jisho/catppuccin.user.css Outdated Show resolved Hide resolved
styles/jisho/catppuccin.user.css Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants