Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fabricmc): init #1275

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

feat(fabricmc): init #1275

wants to merge 18 commits into from

Conversation

KnownSH
Copy link

@KnownSH KnownSH commented Sep 8, 2024

🎉 Theme for FabricMC 🎉

preview (3)

💬 Additional Comments 💬

🗒 Checklist 🗒

  • I have read and followed Catppuccin's submission guidelines.
  • I have made a new directory underneath /styles/<name-of-website> containing the contents of the /template directory.
    • I have ensured that the new directory is in lower-kebab-case.
    • I have followed the template and kept the preprocessor as LESS.
  • I have made sure to update the
    userstyles.yml
    file with information about the new userstyle.
  • I have included the following files:
    • catppuccin.user.css - all the CSS for the userstyle, based on the
      template.
    • preview.webp - composite image of all four individual flavor screenshots (taken with the default accent color of mauve) stitched together, generated via Catwalk.

@KnownSH
Copy link
Author

KnownSH commented Sep 9, 2024

All three main parts of the website (docs.fabricmc.net [VuePress], fabricmc.net, and fabricmc.net/wiki [DokuWiki]) should have proper styling.
Note: VuePress uses Prism and DokuWiki uses GeSHi for syntax highlighting.

@KnownSH KnownSH marked this pull request as ready for review September 9, 2024 04:24
@KnownSH KnownSH requested a review from a team as a code owner September 9, 2024 04:24
@uncenter
Copy link
Member

uncenter commented Sep 9, 2024

Looks like they use VitePress, not VuePress. We should hopefully have a theme we can import at some point instead of redefining all the variables here - https://github.com/42Willow/vitepress. I also got around to finally building a Prism.js theme - https://github.com/uncenter/ctp-prismjs - so once that gets transferred we can include it here as well. I'll take a look at how we can theme GeSHi!

@uncenter
Copy link
Member

uncenter commented Sep 9, 2024

Ah it's actually Shiki that's used, not Prism.js.

- Includes labels for which CSS rule does which syntax highlighting style
Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the PR.
The hr under the download button is unthemed.
{A7C73C01-8E22-4B1D-B6E1-746CC91E64B1}

otherwise i have no placeable issues

styles/fabricmc/catppuccin.user.css Outdated Show resolved Hide resolved
styles/fabricmc/catppuccin.user.css Outdated Show resolved Hide resolved
styles/fabricmc/catppuccin.user.css Outdated Show resolved Hide resolved
Copy link
Member

@uncenter uncenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

styles/fabricmc/catppuccin.user.css Show resolved Hide resolved
styles/fabricmc/catppuccin.user.css Outdated Show resolved Hide resolved
Co-authored-by: uncenter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants