Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WPF - Allow ToolTip timer configuration #4389

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amaitland
Copy link
Member

@amaitland amaitland commented Feb 9, 2023

Related to issue #4048

Summary:
Allow programmatic configuration of ToolTip timer delay.

Changes:

  • Can set initial show delay in xaml via existing ToolTipService e.g. ToolTipService.InitialShowDelay="100"
  • If InitialShowDelay = 0 then no timer is used and ToolTip is immediately shown
  • Previous delay was 500ms, new delay is the .Net default (typically 1000ms)
  • ToolTipService.GetInitialShowDelay is currently only called in OnLoaded, setting the delay dynamically is not currently supported. Simplest option is to set the delay in xaml

How Has This Been Tested?

  • Manually via CefSharp.Wpf.Example

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Updated documentation

Checklist:

  • Tested the code(if applicable)
  • Commented my code
  • Changed the documentation(if applicable)
  • New files have a license disclaimer
  • The formatting is consistent with the project (project supports .editorconfig)

- Can set initial show delay in xaml via existing ToolTipService e.g. ToolTipService.InitialShowDelay="100"
- If InitialShowDelay = 0 then no timer is used and ToolTip is immediately shown
- Previous delay was 500ms, new delay is the .Net default (typically 1000ms)

Related to issue #4048
@amaitland amaitland self-assigned this Feb 9, 2023
@amaitland
Copy link
Member Author

If InitialShowDelay = 0 then no timer is used and ToolTip is immediately shown

Related discussion at #4048 (comment)

There's still a few other cases that should be tested.

@AppVeyorBot
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants