Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve rectangular ___domain module code in Dyno #25684

Draft
wants to merge 61 commits into
base: main
Choose a base branch
from

Conversation

riftEmber
Copy link
Member

@riftEmber riftEmber commented Jul 31, 2024

Implement resolution of basic rectangular ___domain type expressions and literals using ChapelDomain module code, replacing the stub compiler implementation.

Includes:

  • Allow new resolution for DomainTypes
  • Rewrite new dmap as new _distribution
  • Try to resolve ___domain type expressions as type of new _domain
  • Try to resolve ___domain literals with chpl__buildDomainExpr/chpl__ensureDomainExpr
  • Get new _domain resolving
  • Get testing working against real _domain type from modules for rectangular domains

Contributes to https://github.com/Cray/chapel-private/issues/6163.

Future work:

  • use associative domains module code as well
  • set up dmapped keyword to resolve a call to chpl_distributed

[reviewer info placeholder]

Depends on these PRs which should be merged first: #25780, #25816, #25931, #25932, #25944, #25954. (Note to self for rebasing: first commit for this branch is Move 'init' call comment closer to where it's created.)

Testing:

  • dyno tests
  • paratest

@riftEmber riftEmber changed the title Dyno resolve chpl__buildDomainRuntimeType Dyno resolve new ___domain Aug 1, 2024
@riftEmber riftEmber force-pushed the dyno-builddomainruntimetype branch 17 times, most recently from 88f1c73 to 79a86ff Compare August 8, 2024 16:09
@riftEmber riftEmber force-pushed the dyno-builddomainruntimetype branch 3 times, most recently from 646a2f8 to bb0b957 Compare August 15, 2024 18:02
@riftEmber riftEmber force-pushed the dyno-builddomainruntimetype branch 5 times, most recently from fae8742 to 3e93857 Compare August 21, 2024 15:53
@riftEmber riftEmber changed the title Dyno resolve new ___domain Dyno resolve ___domain module code Aug 21, 2024
@riftEmber riftEmber force-pushed the dyno-builddomainruntimetype branch 2 times, most recently from 950df4d to a121cdd Compare August 22, 2024 19:29
Most significantly including proper lookup of the type of defaultDist

Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Also remove test-minimal-modules.h as now empty and unused

Signed-off-by: Anna Rift <[email protected]>
Also disable associative array testing until associative domains are
fixed

Signed-off-by: Anna Rift <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant