-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve rectangular ___domain module code in Dyno #25684
Draft
riftEmber
wants to merge
61
commits into
chapel-lang:main
Choose a base branch
from
riftEmber:dyno-builddomainruntimetype
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Resolve rectangular ___domain module code in Dyno #25684
riftEmber
wants to merge
61
commits into
chapel-lang:main
from
riftEmber:dyno-builddomainruntimetype
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riftEmber
force-pushed
the
dyno-builddomainruntimetype
branch
from
August 1, 2024 15:55
71d92dd
to
c6476ea
Compare
riftEmber
changed the title
Dyno resolve
Dyno resolve Aug 1, 2024
chpl__buildDomainRuntimeType
new ___domain
riftEmber
force-pushed
the
dyno-builddomainruntimetype
branch
17 times, most recently
from
August 8, 2024 16:09
88f1c73
to
79a86ff
Compare
riftEmber
force-pushed
the
dyno-builddomainruntimetype
branch
3 times, most recently
from
August 15, 2024 18:02
646a2f8
to
bb0b957
Compare
riftEmber
force-pushed
the
dyno-builddomainruntimetype
branch
5 times, most recently
from
August 21, 2024 15:53
fae8742
to
3e93857
Compare
riftEmber
changed the title
Dyno resolve
Dyno resolve ___domain module code
Aug 21, 2024
new ___domain
riftEmber
force-pushed
the
dyno-builddomainruntimetype
branch
2 times, most recently
from
August 22, 2024 19:29
950df4d
to
a121cdd
Compare
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Most significantly including proper lookup of the type of defaultDist Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Also remove test-minimal-modules.h as now empty and unused Signed-off-by: Anna Rift <[email protected]>
This reverts commit a953fb3. Signed-off-by: Anna Rift <[email protected]>
Also disable associative array testing until associative domains are fixed Signed-off-by: Anna Rift <[email protected]>
riftEmber
force-pushed
the
dyno-builddomainruntimetype
branch
from
September 19, 2024 17:50
9721138
to
1c7598e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement resolution of basic rectangular ___domain type expressions and literals using
ChapelDomain
module code, replacing the stub compiler implementation.Includes:
new
resolution forDomainType
snew dmap
asnew _distribution
new _domain
chpl__buildDomainExpr
/chpl__ensureDomainExpr
new _domain
resolving_domain
type from modules for rectangular domainsContributes to https://github.com/Cray/chapel-private/issues/6163.
Future work:
dmapped
keyword to resolve a call tochpl_distributed
[reviewer info placeholder]
Depends on these PRs which should be merged first: #25780, #25816, #25931, #25932, #25944, #25954. (Note to self for rebasing: first commit for this branch is
Move 'init' call comment closer to where it's created
.)Testing: