Add tests of default intent varargs and the types whose default intent is ref #25904
+51
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t is ref Atomics and syncs are modifiable even after chapel-lang#25887. However, the change there does mean that arrays are not modifiable (though the deprecation message indicates that maybe that's going to stop being the case soon, too?) Anyways, add tests locking in that behavior today, since I've written them. I made the arrays case a future, but if the deprecation message means it's changing then maybe all of them actually pass. ---- Signed-off-by: Lydia Duncan <[email protected]>
|
@lydia-duncan : On #25903, @jabraham17 pointed out that I led you astray, forgetting that while arrays are still |
Signed-off-by: Lydia Duncan <[email protected]>
There's a combination of things going on here. First - I don't think I was operating from a clean branch. Second - while arrays are currently passed by ref, we are deprecating that behavior. So the .good file output matches, and the .future and .bad files are not currently necessary ---- Signed-off-by: Lydia Duncan <[email protected]>
lydia-duncan
added
stat: Ready to Merge
post-release
and removed
stat: Needs Testing
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Atomics and syncs are modifiable even after #25887. However, the change there does mean that arrays are not modifiable (though the deprecation message indicates that maybe that's going to stop being the case soon, too?)
Anyways, add tests locking in that behavior today, since I've written them. I made the arrays case a future, but if the deprecation message means it's changing then maybe all of them actually pass.
Running a fresh checkout of the tests now