fix(group): do not render newline before empty help #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maaslalani
reviewed
Apr 29, 2024
group.go
Outdated
| } | ||
| } | ||
| if foot.Len() > 0 && hasNonSpace(foot.String()) { |
There was a problem hiding this comment.
I think you could also simply check:
Suggested change
| if foot.Len() > 0 && hasNonSpace(foot.String()) { | |
| if strings.TrimSpace(foot.String()) != "" { |
There was a problem hiding this comment.
Errr, right, of course. Thanks 😇
hasNonSpace seems a little silly at second glance. Will remove its definition entirely
|
Do you mind posting an example of a before and after screenshot of which scenario view this fixes, thank you so much! |
ardnew
force-pushed
the
fix/trim-empty-help
branch
from
53f853d
to
dc7912f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same change as PR #117, which was closed due to my incompetence with git. This is now baselined against the latest
main(f922e26).Note that since #117, upstream
charmbracelet/huhchanged the separator "gap" between group content view and keybindings/errors view from using the current theme (g.theme.FieldSeparator.String()) to always using the literal line feed ('\n'). Assuming that was intentional, I've maintained that behavior in this PR.