feat(spinner): improve action

[caarlos0]

I think it would be great to allow the spinner action to return an error, so it simplifies error handling in some cases.

this pr is wip to see what you think, if you think its a good idea, I'll work more on it.

[caarlos0]

another idea would be to have a

type Spinner[T any] struct {
  action func () T
  // ..

and maybe a

type Spinner2[T any, Q any] struct {
  action func() (T, Q)
}

the later being most commonly used as Spinner2[Something, error] I would guess, maybe even worth making the second arg an error always.

[caarlos0]

@maaslalani I reworked some stuff:

• run the action as part as a tea.Cmd
• improve handling when having only ctx, only action, both, or neither

[caarlos0]

I think this might also fix #196

[caarlos0]

one bad thing about this, is that it might be a breaking change 🤔

[ccoVeille]

Can't you support both signature with generics? 🤔

[ccoVeille]

LGTM 👍

[caarlos0]

also added the feature from #172 here

[ccoVeille]

Even it's an example, I won't use a time. Minute here

You can use a 5s delay it would be enough.

I know this timeout won't be reached but three is a problem with a time.Sleep that will block everything. It's somehow OK for an example. But as it's an example, it should be written in a production-ready code

So here is what I'm suggesting

Suggested change

	time.Sleep(time.Minute)
	select {
	case <-time.After(5 * time.Second):
	case <-ctx.Done():
	}

[bashbunni]

We should specify what the difference is between Action and ActionErr

[bashbunni]

I think I'm missing something obvious here - what's wrong with how we're currently handling actions and how does this change improve that?

[caarlos0]

I think I'm missing something obvious here - what's wrong with how we're currently handling actions and how does this change improve that?

if i recall correctly, if you passed both a context and a function it didn't work properly, that's fixed here