refactor: select and multi select fields #332
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashbunni
force-pushed
the
refactor-select
branch
from
609d48f
to
0fea484
Compare
|
Need to update this to use ayman's |
Use a proper type to keep track of selected items. The paginator bubble shouldn't be abused like this if it's not intended to be part of the program UI.
Use selector as a generic item container that holds different types. Note: `selector.Selector` is _not_ concurrent safe.
closes #330
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test:
go test ./... -vin root dirSelectandMultiSelect(burger, gum, theme, readme/multiselect)go get -u github.com/charmbracelet/huh@refactor-select) then tryseq 22 | go run . choose --selected=2,21 --limit=2(or set limit to one or none for single select)Behavioral Changes: