Replaced user with user-entity in session-user #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced req['user'] with req['userEntity'] in controller and changed type from GetUserDto to userEntity in controller and service
2 tasks
…-requserEntity]-in-session-user.controller
annarhughes
approved these changes
Aug 14, 2024
…-requserEntity]-in-session-user.controller
kyleecodes
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced req['user'] with req['userEntity'] in controller and changed type from GetUserDto to userEntity in controller and service
Issue link / number:
#546
What changes did you make?
I refactored the session-user controller and service, so req["userEntity"] is taken instead of req["user"] and refactored the datatypes accordingly.
Why did you make the changes?
Because the refactoring is need as subtask to complete this umbrella ticket
Did you run tests?
I run all unit-tests with "yarn test" and all e2e-tests with cypress all with success.