Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix referral partner courses bug #1095

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Conversation

annarhughes
Copy link
Member

@annarhughes annarhughes commented Aug 21, 2024

What changes did you make?

Fixed bug around referralPartner localstorage string (e.g. bumble?code=123)
When this variable is set in storage, extra params are now split so that bumble?code=123 becomes bumble

Why did you make the changes?

When referralPartner was set in localstorage, 0 courses were being loaded on the courses page, due to bumble?code=123 not being split.

Copy link

vercel bot commented Aug 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bloom-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2024 6:05pm

@annarhughes annarhughes merged commit 3c9ea1e into develop Aug 21, 2024
7 checks passed
@annarhughes annarhughes deleted the fix-referral-partner-bug branch August 21, 2024 18:12
Copy link

cypress bot commented Aug 21, 2024



Test summary

41 0 2 0


Run details

Project Bloom frontend
Status Passed
Commit 3c9ea1e
Started Aug 21, 2024 6:24 PM
Ended Aug 21, 2024 6:31 PM
Duration 07:35 💡
OS Linux Ubuntu -
Browser Chrome 127

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant